Repository navigation
Conversation
…anged The filter treated a falsy old default (false, 0, empty string) as missing, so an unchanged default was generated again as ALTER COLUMN SET DEFAULT. This happens in forward-engineering for any column with a comment, because column comments go through the ALTER script path. Same fix as PostgreSQL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Contributor
Author
|
Superseded by #102 (own sub-task HCK-18634, so it does not merge with the PostgreSQL fix of HCK-18624). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Problem
Same as hackolade/PostgreSQL#210. Column comments always go in separate statements in this plugin, so every column with a comment goes through the ALTER script helpers. In
defaultValueHelper.js, the filternewDefault !== undefined && (!oldDefault || newDefault !== oldDefault)treats a falsy old default (false,0,"") as missing, so an unchanged default is generated again asALTER COLUMN ... SET DEFAULT, next to the inline default of CREATE TABLE.Change
newDefault !== undefined && newDefault !== oldDefaultChecked (helper called directly with node)
falsefalseSET DEFAULT false00SET DEFAULT 0false(separate option)SET DEFAULT falseSET DEFAULT falsefalsetrueSET DEFAULT trueSET DEFAULT truefalseDROP DEFAULTDROP DEFAULTRegression test in Studio, same branch name
HCK-18624(hackolade/studio#6787).🤖 Generated with Claude Code