Skip to content

feat(doctor): run one consented safe fix and verify it (HACK-2218 R7b) - #840

Merged
roodboi merged 10 commits into
nextfrom
codex/hack-2218-doctor-safe-fix
Nov 15, 2026
Merged

roodboi merged 10 commits into
nextfrom
codex/hack-2218-doctor-safe-fix

Conversation

@roodboi

@roodboi roodboi commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

hack doctor --fix --only 'hack gitignore' --yes --json --path <repo> repairs only Hack's managed ignore block, preserves user lines and unrelated findings, then rechecks the file. The schema-1 {ok,data} audit adds data.fix: {id,changed,confirmed} and exits 1 if unconfirmed.

Only this closed safe ID is accepted. Missing consent, other IDs and combinations with other repair modes refuse before discovery or mutation. The repair uses the existing atomic/no-follow writer, rejects adopted/non-Git projects and rechecks project selection before publication. It never invokes broad guided remediation. Ordinary --fix remains unchanged.

R7a metadata (#838) is merged. This PR now targets frozen next 8e7242d; its normal merge resolves the R7a squash/add-add and documentation conflicts without altering the R7b patch (stable patch ID matches the prior reviewed unit). Dependent R7c is #841.

Validation at merge head 2fed4e5: 49 focused tests /329 assertions pass; root typecheck passes (CLI uncached, DB cached); changed-file lint, privacy and docs checks pass. Rebuilt CLI passes all eight relocated native-plan/config-import acceptance scripts with the prepared compiler. Same persistent Opus reviewer clean; fresh exact-head CI/Codex pending. Earlier consent/readback/idempotency and unsafe-input regressions remain intact. No Mac qualification claim or manual Mac dispatch.

HACK-2218 / R7b. The next.17 candidate is frozen; lead owns merging after publication. The final ready note follows exact-head checks, with no push after it.

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hack-docs Ready Ready Preview Nov 14, 2026 2:43pm UTC

Request Review

@linear-code

linear-code Bot commented Nov 14, 2026

Copy link
Copy Markdown

HACK-2218

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T14:44:55.099377Z 2fed4e5 Manual request
🔒 Security Review ✅ Completed 2026-11-14T14:46:45.867718Z 2fed4e5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 98f7178166

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 98f7178166

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Head 1938087 includes a normal merge of R7a's exact-target scope correction e27d899. No targeted-fix implementation change; the one supported ID remains hack gitignore. Updated source-CLI tests for metadata, browser scope, selected fix and machine audit pass (22 tests / 231 assertions at the dependent candidate). Same reviewer is checking the merge provenance. Exact-head CI/Codex pending. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 193808786b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 193808786b

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Head 819ca4dff8ce0b2c1b3ce7bf40bbec5d699d6cbf incorporates the test-only correction for #838's shard 4 failure. Two active/pending adopted-project assertions now explicitly expect R7a's area/scope/fix fields and data.schema:1. Both keep strict whole-object equality and all existing adoption, status/detail, duration, canary and read-only assertions. No product code changed.

Same persistent Opus reviewer clean for the fix and both normal merges. R7a: 13 tests /130 assertions across three files pass. Final stacked head: 21 tests /266 assertions across five files pass, including both adoption cases, machine and selected-fix regressions. Changed-test lint and privacy pass. New exact-head CI/Codex pending; no merge or Mac claim.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 819ca4dff8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 819ca4dff8

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Head 1878ed36de28270eb005071f9fba53e312eff412 carries the type-only follow-up to the adopted-project metadata expectations. The test now imports the exported DoctorJsonCheck contract instead of maintaining an obsolete local five-field type. This fixes TS2769 from #840 shard 8; runtime assertions and product code are unchanged.

Root bun run typecheck passes both at the R7a fix and final stacked head (CLI uncached, DB cached). Final stacked head also passes all five adoption CLI cases /86 assertions; changed-file lint and privacy pass. Same persistent Opus reviewer clean for the fix and exact normal-merge propagation. Fresh exact-head hosted checks and Codex are pending; no Mac or merge claim.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 1878ed36de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 1878ed36de

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Ready for lead: 1878ed36de28270eb005071f9fba53e312eff412 (R7b).

Exact-head checks are settled: all five Linux CLI shards, test focus/fan-in, docs site and secret scan pass (CI 43586725500); separate desktop Linux and macOS build/core-test jobs also pass. Light CI intentionally skips CLI Mac/Docker/native tiers, so the green Docker fan-in does not claim Docker scenarios ran. No manual Mac shard dispatch was made.

Same persistent Opus and current-head Codex code reviews are clean. computer pr review-status: CLEAR at 1878ed36de, zero unresolved bot threads/change requests; base contains R7a at 6e27a9a. Local typecheck and relevant CLI tests pass, including consent/ID/mode refusals, preserved user lines/unrelated state, readback, idempotency and unsafe/read-only nonconfirmation.

Only hack gitignore is advertised/executed as a safe targeted repair. Existing guided --fix remains separate; JSON stays {ok,data:{schema:1,...}}. Dependency order: #838 → #840 → #841. Lead owns freeze/merging; no merge performed. #841's separate optional desktop Mac failure is documented on that PR.

Base automatically changed from codex/hack-2218-doctor-contract to next November 14, 2026 14:34

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Updated candidate: 2fed4e536a93de5e1920264cf89dc380748ee9a0 includes frozen next 8e7242db9466fe14f52b9bfb4513c02fa9d68bf4 by normal merge. The R7b and R7c unit patch IDs match their prior reviewed diffs exactly; same persistent Opus reviewer clean. Local verification and exact scope are updated in the PR description. New exact-head CI/Codex pending. No merge, manual Mac dispatch or ready-for-lead declaration yet; after the final ready note, this head will stay fixed.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 2fed4e536a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2fed4e536a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Ready for lead: 2fed4e536a93de5e1920264cf89dc380748ee9a0.

Normal merge contains frozen next 8e7242db9466fe14f52b9bfb4513c02fa9d68bf4. The R7b diff is identical to the previously reviewed unit (stable patch ID 33391bdf35f69fed54e33c3c9f06b690e0f0c41a); conflicts retain next's squashed R7a plus the safe-fix additions. Same persistent Opus merge review clean. Current-head Codex code review clean; computer pr review-status: CLEAR at 2fed4e536a, zero unresolved bot threads/change requests.

Exact-head CI run 43606326930 passes all five planned Linux shards, test focus/fan-in, required Linux Config compiler/relocated acceptance, docs and secret scan. Local 49 focused tests /329 assertions, root typecheck (CLI uncached, DB cached), lint/privacy/docs, compiled build and all eight relocated CLI acceptance scripts pass.

Separate automatic desktop Linux checks pass; desktop Mac build/core tests remain queued. CLI Mac/Docker/native tiers are deferred by light CI; the Docker fan-in success does not claim Docker scenarios ran. No manual Mac dispatch was made.

This is the final head for lead Mac verification. No further push will be made unless the lead asks. No merge to next; next.17 freeze honored. Dependent #841 contains this merge and remains under its own check settlement.

@roodboi

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Lead note: verified on the Mac batch tree at this head (next 8e7242d + #794 + #840): typecheck, selected test files (the four native-authored files pass in sequence, HACK-2219), the nine relocated acceptance scripts, Rust 1,809 passed, and real-VM smoke, webdb and first-use setup from an empty home. next is frozen as the next.17 candidate while its full release CI run finishes; this merges right after publish if the head has not moved.

🤖 Generated with Claude Code

@roodboi
roodboi merged commit aa08daf into next Nov 15, 2026
23 checks passed
@roodboi
roodboi deleted the codex/hack-2218-doctor-safe-fix branch November 15, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant