Repository navigation
feat(doctor): run one consented safe fix and verify it (HACK-2218 R7b) - #840
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Head 1938087 includes a normal merge of R7a's exact-target scope correction e27d899. No targeted-fix implementation change; the one supported ID remains hack gitignore. Updated source-CLI tests for metadata, browser scope, selected fix and machine audit pass (22 tests / 231 assertions at the dependent candidate). Same reviewer is checking the merge provenance. Exact-head CI/Codex pending. @codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Head Same persistent Opus reviewer clean for the fix and both normal merges. R7a: 13 tests /130 assertions across three files pass. Final stacked head: 21 tests /266 assertions across five files pass, including both adoption cases, machine and selected-fix regressions. Changed-test lint and privacy pass. New exact-head CI/Codex pending; no merge or Mac claim. @codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Head Root @codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: Exact-head checks are settled: all five Linux CLI shards, test focus/fan-in, docs site and secret scan pass (CI 43586725500); separate desktop Linux and macOS build/core-test jobs also pass. Light CI intentionally skips CLI Mac/Docker/native tiers, so the green Docker fan-in does not claim Docker scenarios ran. No manual Mac shard dispatch was made. Same persistent Opus and current-head Codex code reviews are clean. Only |
|
Updated candidate: @codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: Normal merge contains frozen next Exact-head CI run 43606326930 passes all five planned Linux shards, test focus/fan-in, required Linux Config compiler/relocated acceptance, docs and secret scan. Local 49 focused tests /329 assertions, root typecheck (CLI uncached, DB cached), lint/privacy/docs, compiled build and all eight relocated CLI acceptance scripts pass. Separate automatic desktop Linux checks pass; desktop Mac build/core tests remain queued. CLI Mac/Docker/native tiers are deferred by light CI; the Docker fan-in success does not claim Docker scenarios ran. No manual Mac dispatch was made. This is the final head for lead Mac verification. No further push will be made unless the lead asks. No merge to next; next.17 freeze honored. Dependent #841 contains this merge and remains under its own check settlement. |
|
Lead note: verified on the Mac batch tree at this head ( 🤖 Generated with Claude Code |
hack doctor --fix --only 'hack gitignore' --yes --json --path <repo>repairs only Hack's managed ignore block, preserves user lines and unrelated findings, then rechecks the file. The schema-1{ok,data}audit addsdata.fix: {id,changed,confirmed}and exits 1 if unconfirmed.Only this closed safe ID is accepted. Missing consent, other IDs and combinations with other repair modes refuse before discovery or mutation. The repair uses the existing atomic/no-follow writer, rejects adopted/non-Git projects and rechecks project selection before publication. It never invokes broad guided remediation. Ordinary
--fixremains unchanged.R7a metadata (#838) is merged. This PR now targets frozen
next8e7242d; its normal merge resolves the R7a squash/add-add and documentation conflicts without altering the R7b patch (stable patch ID matches the prior reviewed unit). Dependent R7c is #841.Validation at merge head 2fed4e5: 49 focused tests /329 assertions pass; root typecheck passes (CLI uncached, DB cached); changed-file lint, privacy and docs checks pass. Rebuilt CLI passes all eight relocated native-plan/config-import acceptance scripts with the prepared compiler. Same persistent Opus reviewer clean; fresh exact-head CI/Codex pending. Earlier consent/readback/idempotency and unsafe-input regressions remain intact. No Mac qualification claim or manual Mac dispatch.
HACK-2218 / R7b. The next.17 candidate is frozen; lead owns merging after publication. The final ready note follows exact-head checks, with no push after it.