Repository navigation
feat(doctor): add versioned per-check metadata (HACK-2218 R7a) - #838
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f884ba36e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Head Same persistent Opus reviewer clean for the fix and both normal merges. R7a: 13 tests /130 assertions across three files pass. Final stacked head: 21 tests /266 assertions across five files pass, including both adoption cases, machine and selected-fix regressions. Changed-test lint and privacy pass. New exact-head CI/Codex pending; no merge or Mac claim. @codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Head Root @codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: All five planned Linux shards, test focus, required test fan-in, secret scan and docs site checks pass at this exact head (CI run 43586724892). Same persistent Opus reviewer and current-head Codex code review are clean. The exact-target scope finding is fixed, answered and resolved. The audit now adds schema 1 inside CLI macOS/Docker/native tiers are deferred by light CI; the green Docker fan-in does not mean Docker scenarios ran. The separate automatically triggered desktop macOS build is still queued. No manual Mac shard dispatch was made. No Mac runtime qualification or merge is claimed; lead owns the freeze and merge. Dependent PRs: #840 then #841. |
#840) `hack doctor --fix --only 'hack gitignore' --yes --json --path <repo>` repairs only Hack's managed ignore block, preserves user lines and unrelated findings, then rechecks the file. The schema-1 `{ok,data}` audit adds `data.fix: {id,changed,confirmed}` and exits 1 if unconfirmed. Only this closed safe ID is accepted. Missing consent, other IDs and combinations with other repair modes refuse before discovery or mutation. The repair uses the existing atomic/no-follow writer, rejects adopted/non-Git projects and rechecks project selection before publication. It never invokes broad guided remediation. Ordinary `--fix` remains unchanged. R7a metadata (#838) is merged. This PR now targets frozen `next` 8e7242d; its normal merge resolves the R7a squash/add-add and documentation conflicts without altering the R7b patch (stable patch ID matches the prior reviewed unit). Dependent R7c is #841. Validation at merge head 2fed4e5: 49 focused tests /329 assertions pass; root typecheck passes (CLI uncached, DB cached); changed-file lint, privacy and docs checks pass. Rebuilt CLI passes all eight relocated native-plan/config-import acceptance scripts with the prepared compiler. Same persistent Opus reviewer clean; fresh exact-head CI/Codex pending. Earlier consent/readback/idempotency and unsafe-input regressions remain intact. No Mac qualification claim or manual Mac dispatch. HACK-2218 / R7b. The next.17 candidate is frozen; lead owns merging after publication. The final ready note follows exact-head checks, with no push after it. --------- Co-authored-by: Kit <344842+roodboi@users.noreply.github.com>
Doctor's JSON audit now adds
data.schema: 1and per-checkarea, machine/projectscope, andfix: {kind,args,doc_url}inside the existing{ok,data}envelope. Clients can group findings without parsing diagnostic text. Existing statuses, details, payloads, counts and exit codes remain unchanged.The catalog uses closed IDs/prefixes and own-property lookup. Unknown checks are Other/project/manual with no executable args. Trust findings are admin; no safe repair is advertised until the separate R7b targeted path exists. Mixed secrets-hygiene scope is set from its actual inspection context. This PR changes observation metadata only, so a flow diagram adds no useful behavior detail.
Validation: 125 focused tests across 8 files pass, covering metadata, actual mixed-scope observation in an isolated child, JSON, browser checks, command refusals, env keys, secret integrity, daemon guidance and local-network hints. CLI typecheck and quality, changed-file lint, privacy and docs preparation/check pass (existing complexity warnings only). Same persistent Opus reviewer clean at f884ba3. Exact-head hosted CI and Codex review pending; no Mac or full-suite claim, no manual Mac dispatch.
HACK-2218 / R7a. R7b and R7c will be separate small dependent PRs rooted here to avoid duplicating this contract. Lead owns merging; next.17 merge freeze applies.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.