Repository navigation
fix(ci): isolate config compiler Rust tests - #832
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Hosted compiler isolation checkpoint: run 43580334304, Linux job 132403584298 passed the pinned install, compiler checks/tests, evidence upload and compiler build. A later unchanged compiled-bundle check failed at scripts/check-native-env-plan-cli.ts:279: |
|
Normal merge refresh includes next at 5002cf8 and the #820 relocated acceptance fixes for HACK-2236. The merge was automatic: recomputed tree d420a496 matches the index; all nine authored paths remain byte-identical to bc140f0. The 18 runner regressions passed again. Prior hosted compiler isolation/count-parity evidence remains applicable; the refreshed acceptance scripts now need current-head CI. Persistent merge review CLEAN (round 58). No next run rerun/cancel/merge, no manual Mac dispatch, no soak. @codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Ready for lead: 9b0f775 Compiler test isolation follow-up to #798. The shared pinned runner, local fallback install hint and documented unmatched-filter exit behavior are complete. Normal merge of next5002cf87 brought #820's acceptance fix; original nine authored paths stayed byte-identical, and the exact automatic merge tree was reviewed CLEAN (persistent rounds50–51 and58). No further push after this note. Current-head run43584152921: both Linux compiler acceptance lanes, Linux Candidate, all five Linux unit shards, all four Docker shards/fan-in, lifetime, models and docs passed. Each Linux compiler artifact (x64 andARM64) has127 executed,0 ignored,14 discovered binaries; full/ignored stock-Cargo name multisets and JUnit executed-name inventories match exactly. Local18runner tests238assertions, root gates and actionlint pass. Review status: persistent second-family CLEAN; current-head Codex no findings; Pending hosted Mac evidence: Config compiler, Candidate core, unit shards2/8 and3/8; required test fan-in consequently not complete. Ready for the lead's Mac batch, with these pending explicitly disclosed. No manual Mac dispatch or new soak. GitHub says MERGEABLE; next is now1f761ac56 via #836, touching none of this PR's nine authored paths. Per instruction, no freshness-only merge/push. No named job failure and no flake rerun. No next run rerun/cancel/merge; lead owns batch/merge and release freeze. |
The installer fixture failed on Linux shard 7 of run 43578179726 (PR #830 at dc55ab0) although its installer code was unchanged. Structured attempt-1 annotations identify: - `stable update refuses a release with wrong checksum before publication` and the corresponding `wrong version` case: line 153 compares the whole OS temporary directory. The snapshots gain or lose another process's `hack-update-*` directory. - `stable download restarts a truncated transfer and retries 503 within one budget` and its prerelease counterpart: line 173 raises the intentional interruption asynchronously inside the HTTP server. The successful rerun still annotated both fixture errors. Extraction tests now pass a private temporary parent; the implementation still creates a fresh owned directory and preserves the OS-temp default. Retry fixtures use the existing `ReleaseFetch` seam and fail on the consumer's second stream pull, after reading back the written five-byte prefix. Assertions retain exact attempts, complete final bytes and no leftovers. Offline refusal is injected deterministically with exactly three attempts, removing the released-port assumption. Recovery fixture builds run from their own temporary directory, keeping Bun's transient build files outside the checkout. All 17 tests remain, now with 146 assertions (previously 141). Direct fault cases exercise the transfer/installer logic without sockets; the compiled CLI hard-kill/recovery cases retain real HTTP success-path coverage. This does not claim a real TCP-reset qualification. No assertion or timeout was relaxed. Validation: 100 consecutive full-file passes in separate Bun 1.4.4 processes (17 tests / 146 assertions each, zero failures/skips/retries), while 610 other 9-test batches passed, over 523.8 seconds. Concurrent background batches run `release-download-installer`, `self-update` and `release-boundary`; deliberate global-temp directory churn challenges shared-path assumptions. Root typecheck, check/privacy and changed-file lint passed. Persistent Claude review CLEAN (rounds 52–53). The first concurrent attempt exposed checkout-write guard failures from staging after launch and Bun's transient build path; that attempt was retained as failed evidence. The final sequence started after both fixes and contains no retries or reset. Hosted Linux shard and head Codex review pending. No manual macOS dispatch. HACK-2239. Separate from #832. Lead owns merge. <!-- codesmith:footer --> --- <a href="https://backend.blacksmith.sh/track/run-proof?expires=1797241031&installation_model_id=17053&pr_number=834&ref=codesmith_pr_footer&repository=hack-dance%2Fhack&return_to=https%3A%2F%2Fgithub.com%2Fhack-dance%2Fhack%2Fpull%2F834&variant=start_proof&signature=2c7e4ebc57984532d61605b0c13934562dd9ac3e31130f33cacf8bd186a338d0"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-light.svg"><img alt="Start Proof" src="https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-dark-3x.png" width="108" height="28"></picture></a> <sup><a href="https://app.blacksmith.sh/hack-dance/codesmith/hack/pr/834?autoLogin=true&ref=codesmith_pr_footer">Open in [code]smith</a> · Need help on this PR? Tag <code>@codesmith-bot</code> with what you need.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer --> Co-authored-by: Kit <344842+roodboi@users.noreply.github.com>
![https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-dark.svg"><source](https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-dark.svg"><source){kind=link}
![https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-light.svg"><img](https://pr-comments-assets.blacksmith.sh/codesmith/proof-start-proof-light.svg"><img){kind=link}
The compiler's protocol tests spawn children with piped stdin. Threaded libtest on macOS can inherit another test's transient descriptor and delay EOF, the race addressed for runtime-core in #798.
test:config-compilernow shares that process-per-test runner, with pinned nextest 0.9.151, zero retries and separate doctests. CI requires the pin and uploads discovery, stock full/ignored inventories and JUnit per compiler host. The runtime command remains compatible.The local fallback again prints the optional pinned install command without replacing a contributor's installation. An actual tiny-crate probe confirms that an unmatched name filter exits 4 with pinned nextest, versus Cargo's zero-test exit 0; both crate guides document the difference.
Validation: compiler Linux run passed 127 tests across 14 discovered binaries, 0 ignored, plus doctests; full/ignored name multisets equal stock Cargo and JUnit executed names equal the non-ignored inventory. Runner tests: 18/238 assertions; scope/wiring: 12; trusted-policy: 47. Root typecheck, check, privacy and actionlint passed. Persistent Claude review: CLEAN, rounds 50–51. Hosted CI pending. No manual macOS dispatch; protected CI inputs enable automatic full tiers on this PR. No compiler Mac soak requested.
Linux ARM64 archive SHA256
3e35e8f6913af92558ba09d7155f74e35dd1f0024ef3cd891637433ae4eacbddverified against the published digest for cargo-nextest 0.9.151. No Rust production changes.HACK-2203 follow-up. Lead owns merge.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.