Skip to content

fix(test): isolate upgrade installer fault fixtures - #834

Merged
roodboi merged 1 commit into
nextfrom
fix/upgrade-installer-fixture-isolation
Nov 14, 2026
Merged

roodboi merged 1 commit into
nextfrom
fix/upgrade-installer-fixture-isolation

Conversation

@roodboi

@roodboi roodboi commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

The installer fixture failed on Linux shard 7 of run 43578179726 (PR #830 at dc55ab0) although its installer code was unchanged. Structured attempt-1 annotations identify:

  • stable update refuses a release with wrong checksum before publication and the corresponding wrong version case: line 153 compares the whole OS temporary directory. The snapshots gain or lose another process's hack-update-* directory.
  • stable download restarts a truncated transfer and retries 503 within one budget and its prerelease counterpart: line 173 raises the intentional interruption asynchronously inside the HTTP server. The successful rerun still annotated both fixture errors.

Extraction tests now pass a private temporary parent; the implementation still creates a fresh owned directory and preserves the OS-temp default. Retry fixtures use the existing ReleaseFetch seam and fail on the consumer's second stream pull, after reading back the written five-byte prefix. Assertions retain exact attempts, complete final bytes and no leftovers. Offline refusal is injected deterministically with exactly three attempts, removing the released-port assumption. Recovery fixture builds run from their own temporary directory, keeping Bun's transient build files outside the checkout.

All 17 tests remain, now with 146 assertions (previously 141). Direct fault cases exercise the transfer/installer logic without sockets; the compiled CLI hard-kill/recovery cases retain real HTTP success-path coverage. This does not claim a real TCP-reset qualification. No assertion or timeout was relaxed.

Validation: 100 consecutive full-file passes in separate Bun 1.4.4 processes (17 tests / 146 assertions each, zero failures/skips/retries), while 610 other 9-test batches passed, over 523.8 seconds. Concurrent background batches run release-download-installer, self-update and release-boundary; deliberate global-temp directory churn challenges shared-path assumptions. Root typecheck, check/privacy and changed-file lint passed. Persistent Claude review CLEAN (rounds 52–53). The first concurrent attempt exposed checkout-write guard failures from staging after launch and Bun's transient build path; that attempt was retained as failed evidence. The final sequence started after both fixes and contains no retries or reset. Hosted Linux shard and head Codex review pending. No manual macOS dispatch.

HACK-2239. Separate from #832. Lead owns merge.


Start Proof
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hack-docs Ready Ready Preview Nov 14, 2026 9:37am UTC

Request Review

@roodboi

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T09:39:08.696090Z 34b7780 Manual request
🔒 Security Review ✅ Completed 2026-11-14T09:40:15.240035Z 34b7780 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@linear-code

linear-code Bot commented Nov 14, 2026

Copy link
Copy Markdown

HACK-2239

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 34b7780be7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 34b7780be7

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Ready for lead: 34b7780

HACK-2239: private extraction parents remove shared-temp snapshots; consumer-driven response faults replace timed server errors and released-port assumptions. All assertions and timeouts retained, with five additional assertions. Recovery fixture compilation stays inside its owned temp directory.

  • Hosted run 43581415437 succeeded at this exact head. All five Linux shards and both required checks passed. tests/upgrade-installer.test.ts ran on Linux shard 4; its duration artifact records 5.1 seconds, and the job has zero failure annotations. Earlier cancelled run 43581411809 was superseded.
  • Local: 100 consecutive full-file Bun 1.4.4 processes, each 17 tests /146 assertions, zero failures/skips/retries, 523.823 seconds. Concurrent 610 passing nine-test batches plus owned global-temp churn. Root typecheck, check/privacy and changed-file lint passed.
  • Review status: persistent second-family Claude CLEAN (rounds 52–53); current-head Codex completed with no findings; CLEAR at 34b7780be7 with zero unresolved threads or change requests. All bot comments read.

Based on next 5965b23. No manual macOS dispatch; Mac/Docker execution remains deferred by the light-PR policy. Direct fault fixtures use the existing request seam, while compiled CLI recovery retains real HTTP success-path coverage. No real TCP-reset qualification claimed. Scratch cleaned and durable validation evidence retained. No merge; lead owns the batch.

@roodboi

roodboi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

Lead note: verified on the Mac batch tree at this head (next 5002cf8 + #829 + #834: typecheck, 169 selected test files, the nine relocated acceptance scripts, VM smoke); review-status CLEAR. next is frozen as the next.17 candidate until its hosted run completes and the prerelease publishes; this merges right after, if the head has not moved.

🤖 Generated with Claude Code

@roodboi
roodboi merged commit 5e82ad6 into next Nov 14, 2026
22 of 34 checks passed
@roodboi
roodboi deleted the fix/upgrade-installer-fixture-isolation branch November 14, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant