Skip to content

Delete unimported pre-Studio dashboard files - #2598

Merged
groupthinking merged 2 commits into
mainfrom
cursor/web-dead-dashboard-3cca
Nov 5, 2026
Merged

groupthinking merged 2 commits into
mainfrom
cursor/web-dead-dashboard-3cca

Conversation

@kk-agent

@kk-agent kk-agent commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Canonical issue

Closes #2599

Outcome

Removes the remaining pre-Studio dashboard files in apps/web that a fresh import search showed were unused by live routes and Studio.

Import-check rule: a file was deleted only when every reference was a test or another file in this same dead cluster. A live route or Studio import kept the file.

Scope

  • Included deletions:
    • apps/web/src/app/ContactForm.tsx
    • apps/web/src/lib/contact-form-validation.ts
    • apps/web/src/lib/__tests__/contact-form-validation.test.ts
    • apps/web/src/lib/dashboard-analysis.ts
    • apps/web/src/lib/__tests__/dashboard-analysis.test.ts
    • apps/web/src/lib/agent-types.ts (Agent Flow Visualizer types, zero importers)
    • apps/web/src/lib/orchestrator-rail-seeding.ts
    • apps/web/src/lib/__tests__/orchestrator-rail-seeding.test.ts
    • Dropped the ContactForm source read from apps/web/src/lib/__tests__/landing-style-safety.test.ts
  • Already absent on current main (nothing to delete): DashboardCanvasView, VideoCanvasStage, AgentDashboard, EventList, TranscriptViewer, InteractiveTranscript UI, FeedbackWidget, AgentFlowVisualizer, PipelineProgress, TracePanel, ConsensusIndicator, ResultsViewer, AnalysisPanel, OrchestratorRail component, PreferencesPanel, video-generator, BillingStatusBanner, use-dashboard-detail, UI-only action-agent-store, agent-pipeline.ts, use-builtin-ai, services/builtin-ai, use-realtime-voice, and UI kit files ui/Card, Input, Badge, tabs, textarea, resizable, SuggestedPrompts, ui/index.ts.
  • Explicitly excluded / kept because a live route or Studio still imports them:
    • /dashboard, /app, /prototype, /features, /playground redirects
    • Video Pack, OneLoopStudio, G.A.T.E. (apps/web/src/lib/gate-transition.ts and gate tests), Upstash pack store, pricing
    • apps/web/src/store/dashboard-store.ts and dashboard-types.ts (OneLoopStudio and Studio task panes)
    • apps/web/src/lib/action-agent.ts (/api/agents/actions)
    • apps/web/src/lib/preferences.ts and apps/web/src/app/api/v1/preferences/route.ts
    • apps/web/src/app/api/dashboard/route.ts
    • UI kit still imported by Studio or GroundedSpecReview: ui/Button, ui/alert, ui/empty, ui/field, ui/label, ui/separator
    • CONTACT_EMAIL in apps/web/src/lib/constants.ts (privacy and terms pages)
  • Python runtime and the cleanup plan file are unchanged.

Risk

  • Risk level: low
  • Failure mode: a dynamic import the static search missed would fail type-check. tsc --noEmit passed after the deletions.
  • Rollback: revert this commit.

Verification

Head 1cfe32e77.

  • Focused tests: npm --workspace=apps/web run type-check; vitest run for landing-style-safety.test.ts, home-sell-surface.test.ts, proxy-auth-gate.test.ts, and gate-transition.test.ts (4 files, 54 tests passed). Tests that imported the deleted modules were removed with those modules.
  • Required CI
  • Review threads resolved

Production evidence

Not applicable. These modules had no live route or Studio importer, so production behavior for Studio, Video Pack, G.A.T.E., and pricing is unchanged.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval
Open in Web Open in Cursor 

Remove apps/web modules whose only references were tests or the same dead cluster.

Co-authored-by: garveyht <garveyht@gmail.com>
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 5, 2026 1:36pm UTC

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-05T01:40:54.017702Z
We couldn’t complete this review. Comment @codex review to try again.
1cfe32e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ PR title should follow conventional commits format
⚠️ Large PR detected (629 lines changed)

@github-actions github-actions Bot added javascript Pull requests that update javascript code tests labels Nov 5, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Repository reconciliation: this PR does not reference exactly one canonical issue.

Please add a Closes #<issue> reference in the PR description so it can be tracked against the delivery plan.

See governance: #898

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Test Results: ALL TESTS PASSED

Metric Value
Status 🟢 GREEN
Total Tests
Passed 16
Failed
Deployment https://v0-uvai-k9oflneig-garv1.vercel.app
Test Output
n every request without persisting it�[32m 1�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mhomepage returns 200 with HTML�[32m 153�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mfeatures page contains template/workflow markup�[32m 183�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mfeatures page surfaces at least 5 workflow/template indicators�[32m 168�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mVideo Pack Pipeline�[2m > �[22mPOST /api/video/pack accepts a YouTube URL without hanging�[33m 2111�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mVideo Pack Pipeline�[2m > �[22mGET /api/video/pack resolves to a ready pack with evidence lineage�[33m 650�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22mmissing URL returns 400, not a hang�[32m 96�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22minvalid URL returns 400 quickly, not a hang�[32m 96�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22mPOST /api/video/pack with no body returns 400�[32m 128�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mDashboard�[2m > �[22m/dashboard returns 200�[32m 179�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mDashboard�[2m > �[22m/dashboard contains agent or pipeline visualization markup�[32m 120�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mAPI Health�[2m > �[22mGET /api returns a response (not 404)�[32m 245�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mAPI Health�[2m > �[22mretired /api/pipeline routes are gone (no pipeline served)�[32m 59�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mStatic Assets�[2m > �[22mhomepage has proper meta tags�[32m 102�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mStatic Assets�[2m > �[22m/features page returns 200�[32m 135�[2mms�[22m�[39m

�[2m Test Files �[22m �[1m�[32m1 passed�[39m�[22m�[90m (1)�[39m
�[2m      Tests �[22m �[1m�[32m16 passed�[39m�[22m�[90m (16)�[39m
�[2m   Start at �[22m 01:42:53
�[2m   Duration �[22m 5.96s�[2m (transform 54ms, setup 0ms, import 69ms, tests 5.76s, environment 0ms)�[22m


@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Test Results: ALL TESTS PASSED

Metric Value
Status 🟢 GREEN
Total Tests
Passed 16
Failed
Deployment https://v0-uvai-3d364of7t-garv1.vercel.app
Test Output
ss on every request without persisting it�[32m 1�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mhomepage returns 200 with HTML�[32m 131�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mfeatures page contains template/workflow markup�[32m 137�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mfeatures page surfaces at least 5 workflow/template indicators�[32m 130�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mVideo Pack Pipeline�[2m > �[22mPOST /api/video/pack accepts a YouTube URL without hanging�[33m 1693�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mVideo Pack Pipeline�[2m > �[22mGET /api/video/pack resolves to a ready pack with evidence lineage�[33m 590�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22mmissing URL returns 400, not a hang�[32m 63�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22minvalid URL returns 400 quickly, not a hang�[32m 58�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22mPOST /api/video/pack with no body returns 400�[32m 70�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mDashboard�[2m > �[22m/dashboard returns 200�[32m 120�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mDashboard�[2m > �[22m/dashboard contains agent or pipeline visualization markup�[32m 93�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mAPI Health�[2m > �[22mGET /api returns a response (not 404)�[32m 210�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mAPI Health�[2m > �[22mretired /api/pipeline routes are gone (no pipeline served)�[32m 35�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mStatic Assets�[2m > �[22mhomepage has proper meta tags�[32m 77�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mStatic Assets�[2m > �[22m/features page returns 200�[32m 88�[2mms�[22m�[39m

�[2m Test Files �[22m �[1m�[32m1 passed�[39m�[22m�[90m (1)�[39m
�[2m      Tests �[22m �[1m�[32m16 passed�[39m�[22m�[90m (16)�[39m
�[2m   Start at �[22m 13:37:30
�[2m   Duration �[22m 5.08s�[2m (transform 57ms, setup 0ms, import 71ms, tests 4.87s, environment 0ms)�[22m


@groupthinking
groupthinking merged commit e079630 into main Nov 5, 2026
30 checks passed
@groupthinking
groupthinking deleted the cursor/web-dead-dashboard-3cca branch November 5, 2026 13:42

This branch was successfully deployed

1 active deployment
Preview — edb28c43 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete unimported contact form and dashboard leftovers

3 participants