Repository navigation
chore(audit): delete zero-importer Python modules and dead backend imports - #2565
Conversation
Remove modules nothing imports and the dead backend import sites those modules left behind. Co-authored-by: KK <kk-agent@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Please add a See governance: #898 |
🔍 PR Validation |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41e2e94759
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Route to Vercel API | ||
| elif endpoint.startswith("https://api.vercel.com"): | ||
| if endpoint.startswith("https://api.vercel.com"): | ||
| return await self._call_vercel_api(action, payload) |
There was a problem hiding this comment.
Preserve explicit failures for the removed tool routes
When running the legacy pipeline through scripts/testing/run_orchestrator.py, the unchanged config/agent_network.json still routes video ingestion to localhost:8010 and code generation to internal://ai_code_generator. Removing their handlers makes both calls fall through to static {"status": "routed", ...} responses instead of the explicit errors previously returned for unavailable implementations. VideoPipelineOrchestrator._execute_agent_stage treats any response without an error key as successful, so it now emits successful stage events, can record successful VERA proofs, and passes empty routing metadata downstream without processing the video or generating code. Keep explicit unsupported/unavailable errors for both removed routes rather than allowing these configured actions to fall through.
Useful? React with 👍 / 👎.
Stop agent network config and pipeline dispatch from calling the removed YouTube and code-generator handlers, and drop the routed success returns those calls used. Co-authored-by: KK <kk-agent@users.noreply.github.com>
|
|
||
| # Route to Vercel API | ||
| elif endpoint.startswith("https://api.vercel.com"): | ||
| if endpoint.startswith("https://api.vercel.com"): |
Resolve config/agent_network.json against #2565: keep main's tool edits and drop the seven uvai-skills agents and the gtm-skills server, as this PR intends.
Deletes Python modules nothing imports, and removes dead import sites for the deleted backend.
Closes #2328
#2328 covers three kinds of leftovers: archived folders, deleted-backend Python stubs, and docs tied to removed systems. #2557 (archived folder), #2560 (obsolete docs) and #2565 (deleted-backend stubs) together cover all three, and all three carry this closing keyword.
docs/knowledge_prototypesis the only archived folder left on main. This PR covers the deleted-backend-stub part.Findings
Done:
src/backend/—ActionRepositoryhad no other hit. Deleted the empty package and in-memory repository.src/youtube_extension/experiments/— 19from experiments import *re-exports (the audit counted 20). No importer of this tree.src/experiments/kept.src/youtube_extension/intelligence/—__init__.pyimports.agents,.gemini, and.multimodal, which are not in the tree. No importer. Deleted.src/youtube_extension/integrations/cloud_ai.py— import resolves tocloud_ai/__init__.py. The module file never loads. Deleted.processors/video_processor.py,services/video_processor_facade.py,services/pipeline_job_store.py,core/blocking_io.py— no Python importers. Blocking I/O callers useintegrations/cloud_ai/blocking_io.py. Deleted.src/integration/test_file.txtandsrc/agents/prompts/debug_prompts.js— no references. Deleted.services/agents/agent_orchestrator.py,hybrid_vision_agent.py,video_master_agent.py— tests already importservices/agents/adapters/. No test import updates. Deleted.src/agents/enhanced_video_processor.pyandsrc/agents/video_to_action_workflow.py— no importer besides each other, and no tests. Deleted.mcp_agent_network.py— removed theget_youtube_toolbranch and theyoutube_extension.backend.ai_code_generatortry.mcp_ecosystem_coordinator.py— removed thebackend.containers.service_containertry and the loop that only called it.pipeline_orchestrator.py— removed thebackend.llm_routerimport that then passed.integrations/__init__.py— removed the module docstring that listed Frontend, Deployment, Optimization, and QA integrations that are not in the tree.Skipped:
src/integration/gemini_video_fix.py—tests/unit/test_gemini_parameters.pyimportsintegration.gemini_video_fixthrough importlib. Left in place.Not touched:
src/youtube_extension/main.py,cli.py,services/ai/hybrid_processor_service.py,src/skills/,src/uvai/ml/.Verification
python3 -m compileall -q src/passed.pytest tests/unit/(CI flags): 3052 passed. The other 11 failed only because this environment has nopythonbinary on PATH (bash: python: command not foundintest_dependency_review_workflow.py). Re-ran that file withpythonon PATH: 24 passed.pytest tests/test_skills_integration.py tests/security/test_local_mcp_config.py tests/security/test_mcp_catalog_approval.py -q -o addopts='': 72 passed.41e2e947: Python 3.11, Python 3.12, guards, build, lint-python, and lint-frontend passed.CI / test-frontendfailed onhome-sell-surface.test.tslooking forprepares proposed work and build rails for you to review in Studio.apps/web/src/app/page.tsxsaysStudio prepares proposed work and build rails for you to review.That mismatch is already onmain(cd7e1998f); main'stest-frontendjob is red for the same reason. This pull request does not change web files.No web files changed, so npm ci, build, lint, and test were not run locally.