Skip to content

ci: temporarily increase import diff threshold from 100ms to 300 #18988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 2 commits into from
Nov 4, 2026
+4 −1
Merged

ci: temporarily increase import diff threshold from 100ms to 300 #18988

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871b51e
ci: temporarily increase import diff threshold from 100ms to 300
parthea Nov 4, 2026
fcacd9b
Merge remote-tracking branch 'origin/main' into increase-diff-threshold
parthea Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ci/run_single_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,10 @@ case ${TEST_TYPE} in
else
echo "INFO: Successfully installed dependencies for ${PACKAGE_NAME} on Python ${PY_VERSION}."
if [ -f "${BASELINE_CSV}" ]; then
python ${PROFILER_SCRIPT} --package ${PACKAGE_NAME} --iterations 11 --fail-threshold 5000 --diff-baseline "${BASELINE_CSV}" --diff-threshold 100
# TODO(https://github.com/googleapis/google-cloud-python/issues/18987):
# Temporarily increase --diff-threshold from 100 to 300 to unblock presubmits
# while we investigate the cause of the import latency.
python ${PROFILER_SCRIPT} --package ${PACKAGE_NAME} --iterations 11 --fail-threshold 5000 --diff-baseline "${BASELINE_CSV}" --diff-threshold 300
else
python ${PROFILER_SCRIPT} --package ${PACKAGE_NAME} --iterations 11 --fail-threshold 5000
fi
Expand Down
Loading