Skip to content

ci: temporarily increase import diff threshold from 100ms to 300 - #18988

Merged
ohmayr merged 2 commits into
mainfrom
increase-diff-threshold
Nov 4, 2026
Merged

ohmayr merged 2 commits into
mainfrom
increase-diff-threshold

Conversation

@parthea

@parthea parthea commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

See follow up issue #18987. This PR is needed to unblock #18986

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily increases the --diff-threshold parameter from 100 to 300 in ci/run_single_test.sh to unblock presubmits while investigating import latency issues. A TODO comment referencing GitHub issue #18987 has been added to document this temporary change. There are no review comments, so I have no feedback to provide.

@parthea
parthea marked this pull request as ready for review November 4, 2026 16:17
@parthea
parthea requested a review from a team as a code owner November 4, 2026 16:17
@ohmayr
ohmayr merged commit 06dd994 into main Nov 4, 2026
120 checks passed
@ohmayr
ohmayr deleted the increase-diff-threshold branch November 4, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants