Skip to content

feat: update API sources and regenerate - #18986

Open
zhumin8 wants to merge 2 commits into
mainfrom
feat-update-sources-2026-11-04
Open

feat: update API sources and regenerate#18986
zhumin8 wants to merge 2 commits into
mainfrom
feat-update-sources-2026-11-04

Conversation

@zhumin8

@zhumin8 zhumin8 commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update googleapis API sources and regenerate all Python libraries.

Debug Info

System Details

  • Python version: Python 3.13.15
  • Go version: go version go1.26.8 linux/amd64
  • OS: Linux 7.1.6-1rodete1-amd64 x86_64
  • Librarian version: v0.51.0

Commands Executed

  • go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 update sources.googleapis
  • go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 install
  • go run github.com/googleapis/librarian/cmd/librarian@v0.51.0 generate --all
  • git add .
  • git commit -m "feat: update API sources and regenerate"

Included googleapis CLs

google/chat/v1

google/cloud/auditmanager/v1

google/cloud/backupdr/v1

google/cloud/backupdr/v1beta

google/cloud/batch/v1alpha

google/cloud/chronicle/v1

google/cloud/compute/v1

google/cloud/compute/v1beta

google/cloud/dataform/v1

google/cloud/dataform/v1beta1

google/cloud/developerconnect/v1

google/cloud/discoveryengine/v1

google/cloud/memorystore/v1beta

google/cloud/modelarmor/v1

google/cloud/networkmanagement/v1

google/cloud/secretmanager/v1

google/cloud/sql/v1

google/cloud/sql/v1beta4

google/devtools/cloudbuild/v1

google/iam/admin/v1

google/maps/navconnect/v1

google/maps/routeoptimization/v1

google/maps/solar/v1

@zhumin8
zhumin8 requested review from a team as code owners November 4, 2026 15:22
@snippet-bot

snippet-bot Bot commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 229 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant updates to several Google Cloud Python client libraries, including inline citations in google-apps-chat, parameter overrides in google-cloud-auditmanager, and comprehensive auto-protection and restore verification APIs in google-cloud-backupdr. The review feedback correctly identifies critical runtime bugs in the autogenerated async and sync sample codes for creating auto-protection policies, where repeated fields are incorrectly accessed directly as attributes instead of being initialized as lists, which would lead to an AttributeError at runtime.

Comment thread ...les/generated_samples/backupdr_v1_generated_backup_dr_create_auto_protection_policy_async.py Resolved
Comment thread ...ples/generated_samples/backupdr_v1_generated_backup_dr_create_auto_protection_policy_sync.py Resolved
This was referenced Nov 4, 2026
Open
Merged
@zhumin8

zhumin8 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Heads-up for the reviewer: this PR includes an approved breaking change in Secret Manager v1 (googleapis googleapis/googleapis@e99a085652, fix!: update EnableManagedRotationRequest ... rename oneof credentials to oneof credential). The credentials oneof / CloudSQLSingleUserCredentials nested type in EnableManagedRotationRequest are replaced by a top-level CloudSqlSingleUserCredentials and oneof credential. No CI check flagged it here, so merging as feat: would release it as a minor version of google-cloud-secret-manager (currently 2.31.0, GA). Please decide whether this needs a major bump or a release note.

🤖 Posted by an AI agent on behalf of zhumin.

ohmayr pushed a commit that referenced this pull request Nov 4, 2026
@parthea
ci: temporarily increase import diff threshold from 100ms to 300 (#18988
06dd994 
)

See follow up issue
#18987. This PR
is needed to unblock
#18986
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ohmayr ohmayr

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhumin8 @parthea @ohmayr