Repository navigation
Pack a native-endian directive as the machine actually packs it - #431
Merged
Merged
Conversation
S/s, L/l, I/i, Q/q, J/j and f/F/d/D are native-endian by definition, so the byte content this suite asserted was an expectation that only ever held on half the architectures. The nightly runs on s390x, which is the other half, and has been red every night since 2026-08-07 on exactly the nine subtests this touches. The implementation was right all along: it packs in the host's order, which is what MRI does. The test asked it to be little-endian. `native(le, be)` picks the expectation by what the running binary actually stores, so both halves assert the real thing rather than one half asserting nothing. The explicitly-ordered directives — n, N, v, V, e, E, g, G and the < > modifiers — are untouched and keep their literal bytes, which is the point of them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Verified on the lane that catches it. This machine is little-endian and cannot make the claim, so both this and #432 were put on Run 32661057000 — all four green, after seventeen consecutive red nights: Not a green tick taken on trust: the s390x log has 0 |
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arch-qemu-nightlyhas been red every night since 2026-08-07 — seventeen nights — and the s390x job's whole failure is nine subtests ofTestPackUnpack/TestPackUnpackModifiers:The implementation is right and the test was wrong.
S/s,L/l,I/i,Q/q,J/jandf/F/d/Dare native-endian by definition — that is what MRI does too — so an expectation written out in one byte order is an expectation that only holds on half the architectures. It held here because the machines that ran it were all little-endian.native(le, be)picks the expectation from what the running binary actually stores (binary.NativeEndian), so both halves assert the real bytes instead of one half asserting nothing.The explicitly-ordered directives —
n,N,v,V,e,E,g,Gand the<>modifiers — are untouched and keep their literal bytes, which is the entire point of them.Proof
go test ./internal/vm/ -run TestPackUnpackgreen here (little-endian), full./internal/vm/green.nativereturns the same literals the file asserted before.arch-qemu-nightlyis dispatched on this branch — the s390x job is the lane that would catch it, and its result is linked in a comment below before this merges.