Repository navigation
Bound the qemu install in the nightly too - #439
Merged
Merged
Conversation
The lane installs qemu with
sudo apt-get update && sudo apt-get install -y qemu-user-static
which is the exact line that sat for the better part of an hour in
go-crdt/crdt, on the same runner image, more than once. Bounding it there
identified the culprit: three attempts of ten minutes each produced not
one line of output from apt-get update, and the install was never
reached. The runner image already ships apt's lists, so the refresh was
not needed at all.
It has not hung here. But this lane runs once a night, takes forty
minutes when it works, and has just come back from seventeen consecutive
red nights — an hour lost to apt would read as another one, and nobody
would know which kind of red it was until they opened the log.
Same shape as the timeout in #436: what decides whether a slow-but-
correct run counts should not be something unrelated to the code.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lane installs qemu with
which is the exact line that sat for the better part of an hour in
go-crdt/crdt, on the same runner image, more than once. Bounding it there identified the culprit: three attempts of ten minutes each produced not one line of output fromapt-get update, and the install was never reached. The runner image already ships apt's lists, so the refresh was not needed at all.It has not hung here. But this lane runs once a night, takes forty minutes when it works, and has just come back from seventeen consecutive red nights (#431, #432, #436). An hour lost to apt would read as another one, and nobody would know which kind of red it was until they opened the log.
Same shape as the timeout in #436: what decides whether a slow-but-correct run counts should not be something unrelated to the code.
Found by auditing rather than by a failure.
actionlintclean.