Repository navigation
refactor(snapshot): retire the shared unaccounted range reader - #162
Merged
Ivanbeethoven merged 3 commits intoOct 7, 2026
Conversation
…/workspace-v3-shared-range-retirement # Conflicts: # tests/mst2_canonical_reader_http.rs
Ivanbeethoven
marked this pull request as ready for review
October 7, 2026 07:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Ivanbeethoven
merged commit Oct 7, 2026
73b8d5b
into
fix/mst2-metadata-not-ready-client
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining no-pages durable hydration path returned unaccounted Vec ranges through ChunkedFile. Complete the actual fixed-SID directory walk before issuing private online file authority, stream through the owned range reader, and keep its byte owner alive through the CAS write. Canonical metadata-pages callers retain strict fixed-root membership.
Physically remove range.rs, ChunkedFile, BoundedCache and the Vec writer adapter. Retain serving constants and chunk_len in their appropriate modules, and use a fixed sixteen-slot leaf LRU with hit refresh and same-key replacement. This intentionally removes the old public Rust API without an alias or compatibility feature. MST/2 wire identifiers remain supported.
Nine new real HTTP regressions cover completed-manifest authority, a 65 MiB file and resume, incomplete/cancelled walks, map/chunk/END and whole-digest failures, low budgets, cancellation with another retained owner, and real 403/410 renewals. Existing proof, request-count, durability and owned FUSE cases remain, including all three MetadataNotReady regressions from #161. The workspace test removes one duplicate reader and its map/leaf calls while retaining all chunk assertions.
Validation at e465352: all ten exact-head checks pass, including strict Clippy, Linux default/all-features, macOS and installer validation. The actual CI checkout has the identical source tree. Each Linux full suite passes 632 tests; macOS library passes 341. Repeated filtered commands and two isolated manifest child invocations are counted separately; existing ignored live cases were not executed. All nine new online HTTP cases, sixteen durable, fifteen owned-range, twenty-eight FUSE and three MetadataNotReady regressions were verified by name. Two complete source reviews and independent native admission pass. Stacked on #161; the diff contains only source and necessary tests.
Latency improvements have not been measured for this change. Owned ranges still copy covering chunks into a range output, and sequential hydration can retain sixteen prior chunks. Removing the public aggregate read_file/read_file_frames wrappers and measuring the warm FUSE read costs are separate follow-ups.