Repository navigation
refactor(workspace): retire aggregate reader APIs after owned migration - #163
Merged
Ivanbeethoven merged 37 commits intoOct 7, 2026
Merged
Conversation
…kspace-v3-resume-aliases
…kspace-v3-cas-small-cache
…d' into refactor/workspace-v3-owned-coordinator-only
…dinator-only' into fix/workspace-v3-stale-errno
…d' into refactor/workspace-v3-owned-coordinator-only
…dinator-only' into fix/workspace-v3-stale-errno
…to refactor/workspace-v3-verified-cas-only
…as-only' into perf/workspace-v3-bounded-cas-workers
…/workspace-v3-shared-range-retirement # Conflicts: # tests/mst2_canonical_reader_http.rs
Ivanbeethoven
marked this pull request as ready for review
October 7, 2026 07:45
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Ivanbeethoven
changed the base branch from
refactor/workspace-v3-shared-range-retirement
to
main
October 7, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public read_file/read_file_frames wrappers retained a second content reader with all-chunk Vec staging and a final assembled allocation. Migrate their remaining test callers to the owned content and batch APIs, then physically remove both wrappers. Durable callbacks retain the paid byte owner through the CAS write.
The buffered-budget fixture now establishes real fixed-root membership through an MTP2 page over bound HTTP. Oversized reads still reject before metadata/body requests; a wrong map is fetched once and rejected before leaf allocation. Canonical capability failures test both owned raw and framed reads. Existing live digest-tampering cases use bound low-level endpoints and assert HTTP 409 to retain server enforcement coverage; those live cases remain ignored.
Validation at 6d63ac9: all ten exact-head checks pass, including Linux default/all-features, strict Clippy, macOS and isolated installer validation. Each Linux full suite passes 632 distinct outer cases; macOS library passes 341, with 44 explicit additional cases. Child invocations and repeated commands are counted separately. All nine online, sixteen durable, fifteen owned-range, twenty-eight FUSE, buffered-budget and canonical HTTP tests pass by name, including all three MetadataNotReady regressions. Two complete source reviews, independent native admission and the 147-file committed source identity pass. The actual CI checkout has the identical source tree. Stacked on #162; only seven source/test files change.
This intentionally removes the old public Rust APIs without compatibility aliases. MST/2 wire APIs remain. Latency, copying and memory improvements have not been measured for this change.