Repository navigation
test(node-integration-tests): Install Flue and pi-durable as package dependencies - #25933
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: 08e35ad (PR test merge using develop at 8592e7e) Against: 8592e7e (develop) · base run #64393 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 52 successful. See the run.
Successful checks
|
mydea
marked this pull request as ready for review
October 30, 2026 10:35
mydea
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 30, 2026 10:36
This was referenced Oct 30, 2026
mydea
force-pushed
the
test/node-integration-tests-pi-root-deps
branch
from
October 30, 2026 11:07
f9cec91 to
2b6ba3d
Compare
nicohrubec
approved these changes
Oct 30, 2026
mydea
added a commit
that referenced
this pull request
Oct 30, 2026
…es as package dependencies (#25936) **Why:** The typesafe, Bedrock and MCP SDK v1 suites each test a single version that doesn't conflict with anything at the package root. For them, the unlocked per-call `npm install` into a tmp dir (network on every run, unpinned ranges, retries) buys nothing. Installing them once through pnpm makes them locked and faster. It's the same change as #25933 for Flue and pi-durable. For mcp v1, we do not need additional dependencies either, because the package names are actually different for v1 and v2 so we can just install them side-by-side. **How to review:** Hide whitespace. Dropping the options argument re-indents the test bodies, and the assertions are unchanged. **Unsure about:** - `pnpm dedupe` (enforced in CI) moves the shared `@aws-sdk` internals forward a few patches (`@aws-sdk/core` 3.978.1 → 3.978.7, `@smithy/core` 3.35.2 → 3.37.0), because the Bedrock client needs newer ones. - `@google/genai`'s optional `@modelcontextprotocol/sdk` peer now resolves to 1.30.0 instead of 1.32.2. - The aws-serverless unit tests and the aws-serverless, MCP and google-genai suites pass. - `tedious` stays per-suite: the suite tests both the root v19 and v20, so it is a multi-version suite. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dependencies The Flue and pi-durable suites installed their packages with an unlocked `npm install` into a fresh tmp dir for every `createEsmAndCjsTests` call (3 for Flue, 9 for pi-durable, per run and Node version). As root devDependencies they are installed once and pinned by the lockfile. The `engines` reason for keeping them out no longer applies: pnpm only warns about it. Both suites are ESM-only, so they now use `createEsmTests` instead of skipping the CJS mode by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
test/node-integration-tests-pi-root-deps
branch
from
October 30, 2026 12:14
2b6ba3d to
6393bbb
Compare
mydea
enabled auto-merge (squash)
October 30, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The Flue and pi-durable suites installed their packages through
additionalDependencies: an unlockednpm installinto a fresh tmp dir for everycreateEsmAndCjsTestscall. That is 3 installs for Flue and 9 for pi-durable, per run and Node version. Measured locally for Flue: ~16s cold / ~3s warm and 210 MB each time. The unpinned^ranges also let upstream releases reach CI without review. As root devDependencies they are installed once and pinned by the lockfile. They were kept out because theirengines.node >= 22.19brokeyarn installon Node 20. Under pnpm, withoutengine-strict, that is only a warning. Both suites still skip below Node 22.Additionally, we used to use
createEsmAndCjsTestsand then skip for the cjs case. Instead, we can just usecreateEsmTestshere.This prepares the split of the pi-ai integration (#25869).
How to review: Best viewed with whitespace hidden. Dropping the trailing options argument made the formatter re-indent both suites, and switching to
createEsmTestsremoved the hand-written CJS skips. No assertions change. TheallowBuildsentries are for@google/genaiandprotobufjs, which the pi packages pull in.Unsure about:
pnpm dedupe(enforced in CI) moves the root@google/genaifrom 1.20.0 to 1.52.0 and bumps some@aws-sdk/@smithypackages, since pi-ai depends on newer versions. The google-genai and aws-serverless suites pass locally.🤖 Generated with Claude Code