Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 952e2bf (PR test merge using develop at 06db3de) Against: 446679d (develop) · base run #64414
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 not successful, 49 successful. See the run.
Successful checks
|
mydea
force-pushed
the
feat/pi-ai-integration-default
branch
from
October 30, 2026 12:53
7f58fd6 to
91831f6
Compare
Enables `piAiIntegration` by default. Flue and pi-durable send their model calls through pi-ai, so they no longer open chat spans of their own: Flue drops its turn spans and hands the conversation id to the pi-ai span through the scope, and pi-durable drops its `models` proxy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Flue's model calls are now traced by the pi-ai integration, which needs the module hook or bundler plugin, while `instrument()` does not. Without them a Flue app would silently lose its `gen_ai.chat` spans; it now gets a warning on its first model call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
feat/pi-ai-integration-default
branch
from
October 30, 2026 12:54
91831f6 to
c5e394f
Compare
mydea
marked this pull request as ready for review
October 30, 2026 13:21
mydea
requested review from
andreiborza,
chargome,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
October 30, 2026 13:21
mydea
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Flue and pi-durable both send their model calls through pi-ai, and each had its own chat-span code (Flue's turn observations, pi-durable's
modelsproxy). WithpiAiIntegration(#25937) enabled by default, pi-ai becomes the single source ofgen_ai.chatspans, and ~1.1k lines of duplicated span code go away. Flue now hands its conversation id to the pi-ai span through the scope.Stack: #25932 → #25937 → this. #25935 must be merged before #25937 and this: without it, instrumenting pi-ai makes the Cloudflare Flue worker crash at startup. Supersedes #25869.
How to review: The first commit is the switch. The second adds a one-time warning when Flue runs but pi-ai was not instrumented; it's separate so it can be dropped or split off.
Unsure about:
auto.ai.flue/auto.ai.pi_durabletoauto.ai.pi_ai.instrument(createFlueInstrumentation())keeps agent and tool spans but loses chat spans, hence the warning. Setups following our docs are unaffected.flue.turn.purpose(compaction vs. agent turn) is dropped, since pi-ai cannot see it. A possible follow-up is to record compaction the way feat(attributes): Add gen_ai conversation compaction conventions sentry-conventions#723 proposes, once it merges: Flue emitscompaction_start(with amanual/threshold/overflowreason) andcompactionobservations, so it could open agen_ai.compactspan with the summarizinggen_ai.chatnested under it.modelsobject created with pi-ai'screateModels().Release note:
🤖 Generated with Claude Code