Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 6eea71c (PR test merge using develop at 446679d) Against: 446679d (develop) · base run #64414 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 50 successful. See the run.
Successful checks
|
mydea
marked this pull request as ready for review
October 30, 2026 10:41
mydea
requested review from
andreiborza and
isaacs
and removed request for
a team
October 30, 2026 10:41
mydea
force-pushed
the
ref/pi-ai-chat-span-helpers
branch
from
October 30, 2026 12:53
5c3374d to
e186d12
Compare
The span options and response attributes of a pi-ai request move to `ai/pi-ai/chat.ts`, and the pi-ai structural types to `ai/pi-ai/types.ts`, so a pi-ai integration can reuse them. pi-durable's `models` proxy uses them with no change in behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Span attributes drop `undefined` values, so the conditional spreads are not needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ref/pi-ai-chat-span-helpers
branch
from
October 30, 2026 12:54
e186d12 to
437fab0
Compare
chargome
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only moves things around in preparation for follow up work. Functionally nothing should change and it should mostly be stamp-able.
Why: Split out of #25869. The upcoming pi-ai integration creates the same
gen_ai.chatspan as pi-durable'smodelsproxy does today, so the span logic moves toai/pi-ai/first. That way it gets reviewed once, as a move, while pi-durable still uses it. No behavior change: the pi-durable unit tests pass unmodified (only a type import moved).How to review:
ai/pi-ai/chat.tsis the body of the oldtraceModelRequest/endChatSpan, with the origin as a parameter.getPiAiChatSpanOptionsreturns the span options instead of starting the span, because pi-durable keeps the span active while the request is sent (startSpanManual), whereas a channel-based integration starts it inactive.🤖 Generated with Claude Code