ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE - #23368
Open
RulaKhaled wants to merge 22 commits into
Open
Conversation
RulaKhaled
force-pushed
the
feat/segment-name-source-impl
branch
from
August 12, 2026 13:56
8f4804b to
16a4997
Compare
Contributor
size-limit report 📦
|
RulaKhaled
force-pushed
the
feat/segment-name-source-impl
branch
from
August 12, 2026 14:08
16a4997 to
f187f70
Compare
RulaKhaled
changed the title
RulaKhaled
force-pushed
the
feat/segment-name-source-impl
branch
3 times, most recently
from
August 13, 2026 09:47
5a7db5d to
9c2caf1
Compare
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9c2caf1. Configure here.
RulaKhaled
force-pushed
the
feat/segment-name-source-impl
branch
from
August 24, 2026 11:49
a71ca39 to
9acdf57
Compare
Replace sentry.source with sentry.segment.name.source and set the attribute only on segment spans. Fixes #22259 Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
force-pushed
the
feat/segment-name-source-impl
branch
from
August 24, 2026 11:57
9acdf57 to
e6c54fe
Compare
RulaKhaled
marked this pull request as ready for review
August 24, 2026 12:12
RulaKhaled
requested review from
chargome,
isaacs and
msonnb
and removed request for
a team
August 24, 2026 12:12
…ints Restore a same-package migration path where SEMANTIC_ATTRIBUTE_SENTRY_SOURCE was previously public: browser, Remix server, and SvelteKit server/worker. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
s1gr1d
reviewed
Aug 24, 2026
s1gr1d
left a comment
s1gr1d
left a comment
Member
There was a problem hiding this comment.
In general, it's good to go but I would double-check if we'll mention "segment" in user-facing APIs.
Keep SENTRY_SEGMENT_NAME_SOURCE on conflicted tracing sites while taking develop's startSpan import path and span-name fallbacks. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Rename the helper to INTERNAL_setSegmentNameSourceIfSegment and drop 'segment' from the debug log so it is not a user-facing term. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
The unguarded span API lint rule requires browser-facing code to use the browser entry point so span streaming is installed. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
That span is always started under an active pageload or navigation root, so sentry.segment.name.source was stripped immediately. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Keep SENTRY_SEGMENT_NAME_SOURCE while adopting the new conventions op names from develop. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Align unit and E2E tests with segment-only sentry.segment.name.source. Fixes #22259 Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
… HTTP test Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
…Span tests Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a1e0de. Configure here.
Contributor
|
👋 @Lms24, @andreiborza — Please review this PR when you get a chance! |
…nto feat/segment-name-source-tests
Keep tRPC route source on span start so sampling sees it, stop redis cache from deleting source on segment roots, and drop "segment" from the child-span debug warning. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
…nto feat/segment-name-source-tests
…nto feat/segment-name-source-tests
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
…source-impl Bring E2E/unit assertion updates onto impl so CI can pass on a single PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides removing SEMANTIC_ATTRIBUTE_SENTRY_SOURCE and using SENTRY_SEGMENT_NAME_SOURCE instead, this PR also:
CI note: This PR alone is expected to fail CI. It will stay blocked until #23367 is merged into it — that split is intentional to keep the core changes easier to review.
Fixes #22259