Skip to content

test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE - #23367

Open
RulaKhaled wants to merge 5 commits into
feat/segment-name-source-implfrom
feat/segment-name-source-tests
Open

test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE#23367
RulaKhaled wants to merge 5 commits into
feat/segment-name-source-implfrom
feat/segment-name-source-tests

Conversation

@RulaKhaled

@RulaKhaled RulaKhaled commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Test updates for #23368. Merge this to land everything.

Fixes #22259

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.57 kB -0.01% -1 B 🔽
@sentry/browser - with treeshaking flags 26.92 kB +0.02% +4 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB -0.02% -5 B 🔽
@sentry/browser (incl. Tracing) 48.36 kB +0.06% +29 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.38 kB +0.06% +25 B 🔺
@sentry/browser (incl. Tracing, Profiling) 51.27 kB +0.06% +26 B 🔺
@sentry/browser (incl. Tracing, Replay) 87.76 kB +0.04% +35 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.21 kB +0.03% +16 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 92.47 kB +0.04% +32 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 105.17 kB +0.05% +50 B 🔺
@sentry/browser (incl. Feedback) 45.81 kB -0.01% -3 B 🔽
@sentry/browser (incl. sendFeedback) 33.36 kB - -
@sentry/browser (incl. FeedbackAsync) 38.46 kB -0.03% -8 B 🔽
@sentry/browser (incl. Metrics) 29.51 kB -0.04% -11 B 🔽
@sentry/browser (incl. Logs) 29.8 kB +0.02% +3 B 🔺
@sentry/browser (incl. Metrics & Logs) 30.43 kB -0.07% -19 B 🔽
@sentry/react 30.31 kB -0.08% -24 B 🔽
@sentry/react (incl. Tracing) 50.57 kB +0.12% +57 B 🔺
@sentry/vue 35.45 kB +0.16% +54 B 🔺
@sentry/vue (incl. Tracing) 50.36 kB +0.11% +54 B 🔺
@sentry/svelte 28.59 kB -0.04% -9 B 🔽
CDN Bundle 30.36 kB +0.14% +40 B 🔺
CDN Bundle (incl. Tracing) 48.86 kB -0.02% -8 B 🔽
CDN Bundle (incl. Logs, Metrics) 32.56 kB +0.08% +25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 50.74 kB -0.01% -3 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 72.92 kB +0.03% +20 B 🔺
CDN Bundle (incl. Tracing, Replay) 86.31 kB -0.03% -21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB +0.01% +5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 92.07 kB +0.01% +3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.01 kB +0.01% +9 B 🔺
CDN Bundle - uncompressed 89.97 kB +0.04% +29 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 146.13 kB +0.01% +2 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.26 kB +0.04% +29 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.82 kB +0.01% +2 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.23 kB +0.03% +55 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.43 kB +0.02% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.1 kB +0.02% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.12 kB +0.02% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 284.79 kB +0.01% +28 B 🔺
@sentry/nextjs (client) 53.1 kB +0.11% +56 B 🔺
@sentry/sveltekit (client) 48.8 kB +0.11% +53 B 🔺
@sentry/core/server 65.03 kB +0.13% +80 B 🔺
@sentry/core/browser 52.17 kB +0.13% +67 B 🔺
@sentry/node 117.51 kB +0.04% +42 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.18 kB - -
@sentry/node - without tracing 82.06 kB +0.07% +57 B 🔺
@sentry/aws-serverless 91.5 kB +0.07% +57 B 🔺
@sentry/cloudflare (withSentry) - minified 194.89 kB +0.11% +204 B 🔺
@sentry/cloudflare (withSentry) 481.35 kB +0.01% +20 B 🔺

View base workflow run

@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch 6 times, most recently from da8494e to 21a8801 Compare August 12, 2026 16:03
@RulaKhaled RulaKhaled changed the title test: Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE test(core): Update E2E assertions for SENTRY_SEGMENT_NAME_SOURCE Aug 12, 2026
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch 2 times, most recently from 095645a to a9eb1f6 Compare August 13, 2026 09:20
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch from a9eb1f6 to b586685 Compare August 13, 2026 09:22
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch 2 times, most recently from 3746240 to 114d12f Compare August 17, 2026 18:17
@RulaKhaled RulaKhaled self-assigned this Aug 24, 2026
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch 3 times, most recently from f386f68 to 875cfd1 Compare August 24, 2026 11:40
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch from 875cfd1 to e9b3e1a Compare August 24, 2026 11:50
@RulaKhaled

Copy link
Copy Markdown
Collaborator Author

Re-opening to refresh mergeability after squashing/rebasing the stacked base (GitHub still reports dirty despite a clean fast-forward).

@RulaKhaled RulaKhaled closed this Aug 24, 2026
@RulaKhaled RulaKhaled reopened this Aug 24, 2026
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch from e9b3e1a to 2b4e8dd Compare August 24, 2026 11:57
@RulaKhaled
RulaKhaled marked this pull request as ready for review August 24, 2026 12:12
@RulaKhaled
RulaKhaled requested review from a team as code owners August 24, 2026 12:12
@RulaKhaled
RulaKhaled requested review from JPeer264, chargome, isaacs, logaretm, msonnb and nicohrubec and removed request for a team August 24, 2026 12:12

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2b4e8dd. Configure here.

RulaKhaled and others added 4 commits August 24, 2026 18:22
Align unit and E2E tests with segment-only sentry.segment.name.source.

Fixes #22259

Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
… HTTP test

Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-tests branch from 72db291 to d717059 Compare August 24, 2026 16:22
Comment thread packages/core/test/lib/tracing/spans/captureSpan.test.ts
…Span tests

Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename SEMANTIC_ATTRIBUTE_SENTRY_SOURCE to sentry.segment.name.source & drop semanticAttributes re-export

1 participant