test(e2e): Restore @cloudflare/vite-plugin version ranges in Cloudflare E2E test apps#22116
Draft
andreiborza wants to merge 2 commits into
Draft
test(e2e): Restore @cloudflare/vite-plugin version ranges in Cloudflare E2E test apps#22116andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
…st apps
`@cloudflare/vite-plugin@1.43.2` peer-requires `wrangler ^4.108.0`, but
`wrangler@4.108.0` is deprecated ("causing deployment failures in CI,
downgrade to 4.107.1") and `latest` stays at `4.107.1`. Installs resolve
the healthy 4.107.1, so the plugin's `assertWranglerVersion` throws at
build:
The installed version of Wrangler (4.107.1) does not satisfy the peer
dependency required by @cloudflare/vite-plugin (^4.108.0).
Pin the plugin to 1.43.1 (peer `wrangler ^4.107.1`), the last version that
works with the non-deprecated wrangler, instead of adopting the deprecated
4.108.0. astro-6-cf-workers pulls the plugin transitively via
@astrojs/cloudflare, so it uses a pnpm override.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/pin-wrangler-cf-e2e
branch
from
e096435 to
5a764fb
Compare
…re E2E test apps Reverts the temporary `@cloudflare/vite-plugin@1.43.1` pin (and the astro-6-cf-workers pnpm override) now that a plugin release works with a non-deprecated wrangler again, restoring the original ranges so the plugin tracks upstream. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/unpin-wrangler-cf-e2e
branch
from
d70405a to
81d5039
Compare
andreiborza
changed the title
Contributor
size-limit report 📦
|
andreiborza
added a commit
that referenced
this pull request
Jul 8, 2026
…st apps (#22115) `@cloudflare/vite-plugin@1.43.2` peer-requires `wrangler ^4.108.0`, but `wrangler@4.108.0` is **deprecated** ("causing deployment failures in CI, downgrade to 4.107.1") so `latest` stays at `4.107.1`. Installs resolve the healthy 4.107.1 and the plugin throws at build. Fails on `develop` and every PR. Pins the plugin to `1.43.1` (last version whose peer is `wrangler ^4.107.1`) rather than adopting the deprecated wrangler; astro-6-cf-workers gets it transitively so uses a pnpm override. Temporary; #22116 reverts once upstream ships a plugin compatible with a non-deprecated wrangler. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #22115, don't merge yet. Reverts the temporary
@cloudflare/vite-plugin@1.43.1pin (and astro override) back to the original ranges.Merge once
@cloudflare/vite-plugin's latest release peer-accepts a non-deprecated wrangler again (i.e. installing it no longer forceswrangler@4.108.0).