test(e2e): Pin @cloudflare/vite-plugin to 1.43.1 in Cloudflare E2E test apps#22115
Merged
Conversation
logaretm
approved these changes
Jul 8, 2026
…st apps
`@cloudflare/vite-plugin@1.43.2` peer-requires `wrangler ^4.108.0`, but
`wrangler@4.108.0` is deprecated ("causing deployment failures in CI,
downgrade to 4.107.1") and `latest` stays at `4.107.1`. Installs resolve
the healthy 4.107.1, so the plugin's `assertWranglerVersion` throws at
build:
The installed version of Wrangler (4.107.1) does not satisfy the peer
dependency required by @cloudflare/vite-plugin (^4.108.0).
Pin the plugin to 1.43.1 (peer `wrangler ^4.107.1`), the last version that
works with the non-deprecated wrangler, instead of adopting the deprecated
4.108.0. astro-6-cf-workers pulls the plugin transitively via
@astrojs/cloudflare, so it uses a pnpm override.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/pin-wrangler-cf-e2e
branch
from
e096435 to
5a764fb
Compare
andreiborza
changed the title
Member
Author
|
No this is bad actually $ npm view wrangler@4.108.0 |
logaretm
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cloudflare/vite-plugin@1.43.2peer-requireswrangler ^4.108.0, butwrangler@4.108.0is deprecated ("causing deployment failures in CI, downgrade to 4.107.1") solateststays at4.107.1. Installs resolve the healthy 4.107.1 and the plugin throws at build. Fails ondevelopand every PR.Pins the plugin to
1.43.1(last version whose peer iswrangler ^4.107.1) rather than adopting the deprecated wrangler; astro-6-cf-workers gets it transitively so uses a pnpm override. Temporary; #22116 reverts once upstream ships a plugin compatible with a non-deprecated wrangler.