Skip to content

test(android): ignore flaky InternalSentrySdkTest case #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Sep 9, 2026
Merged

test(android): ignore flaky InternalSentrySdkTest case #6078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sentry-android-core/src/test/java/io/sentry/android/core/InternalSentrySdkTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import java.io.ByteArrayOutputStream
import java.io.InputStreamReader
import java.util.concurrent.atomic.AtomicReference
import kotlin.test.BeforeTest
import kotlin.test.Ignore
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertNotEquals
Expand Down Expand Up @@ -612,6 +613,14 @@ class InternalSentrySdkTest {
assertThat(activeSession.get().sessionId).isNotEqualTo(oldSid)
}

// Flaky: intermittently fails with FileNotFoundException reading session.json at the
// `sessionFile.reader()` call below, i.e. persistCurrentSession() did not leave a session file
// on disk by the time this test reads it back. Seen across unrelated PRs, e.g.:
// https://scans.gradle.com/s/55fnn6xhtfyfq/tests/task/:sentry-android-core:testReleaseUnitTest/details/io.sentry.android.core.InternalSentrySdkTest/updateSessionForDroppedEventNonTerminating%20flags%20an%20unhandled%20error%20without%20sending%20an%20envelope?top-execution=1
Comment thread
runningcode marked this conversation as resolved.
// https://scans.gradle.com/s/ojzzz4yxag7rw/tests/task/:sentry-android-core:testReleaseUnitTest/details/io.sentry.android.core.InternalSentrySdkTest/updateSessionForDroppedEventNonTerminating%20flags%20an%20unhandled%20error%20without%20sending%20an%20envelope?top-execution=1
// Disabling until root-caused; see https://github.com/getsentry/sentry-java/pull/5990 for the
// code under test.
@Ignore("Flaky: intermittently fails to find the persisted session.json, needs root-causing")
@Test
fun `updateSessionForDroppedEventNonTerminating flags an unhandled error without sending an envelope`() {
val fixture = Fixture()
Expand Down
Loading