Repository navigation
port: the seven gen_w ports share their block helpers instead of copying them (Closes #8134) - #8135
Merged
Merged
Conversation
…ing them (Closes #8134) duplicate-bodies (tools/dupe_scan.py) was red on master: ends_block, get_last_block, is_blank, line_end, line_starts_with and transform_block were each copied 7 times by the ports of scripts/gen_w310.py .. gen_w322.py (#7513, #7514, #7515, #7520, #7766, #7767, #7768). specs/port/scripts/gen_w_blocks.t27 now holds them once, with the block tests that were repeated in every port, plus wave_suffix_from(line, i, first) and transform_block_from(line, first): every port rewrites three consecutive old waves, so each now keeps only its first wave (307, 308, 311, 312, 313, 315, 319) and its own unchanged wave tests, which pin that nothing behaves differently -- including gen_w311's 308..310 decade crossing. t27c test-report: gen_w_blocks 9/9, each port 2/2, 0 vacuous. dupe_scan exits 0: 658 copies of 7045 bodies, from 700. Each port went from 228 lines to 45. All eight specs sealed. Closes #8134 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 9, 2026 10:06
This was referenced Oct 9, 2026
Merged
gHashTag
pushed a commit
that referenced
this pull request
Oct 9, 2026
… (Refs #8093) This PR carried #8130's six duplicate_bodies_baseline.txt lines so its CI would not inherit master's red duplicate-bodies. #8135 now removes the copies themselves (the seven gen_w ports share gen_w_blocks.t27), and with those lines still here, the gate would fail the moment #8135 lands ("the corpus improved and the ledger did not move"). The ledger file is back to master's; #8130 is withdrawn in favour of #8135. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
3 tasks done
This was referenced Oct 9, 2026
Contributor
This was referenced Oct 9, 2026
gHashTag
added a commit
that referenced
this pull request
Oct 9, 2026
…25 (Closes #8170) (#8173) * t27b ledger: bless lab run a97cb9e, 14 unlisted pass rows, cap 26 -> 25 (Closes #8170) The ledger is rewritten by `tri t27b ratchet --bless` from the t27b lab run at master a97cb9e. Before: UNLISTED 14, all else 0. After: green. Rows 1222 -> 1236; pass 1075 -> 1089, pass_vacuous 122, not_pass 25. max_not_pass falls 26 -> 25, the real non-pass count. self_attention.t27 (#8145, #8051) and eval_arith.t27 (#8086) are not touched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * t27b ledger: add gen_w_blocks.t27 as pass from lab run cd47f56 (Closes #8170) specs/port/scripts/gen_w_blocks.t27 (#8135) passes in the t27b lab run at master cd47f56 (9 tests, 29 asserts) and the ledger had no row. Rows 1236 -> 1237; not_pass 25 = max_not_pass 25, unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * t27b ledger: add seal_identity.t27 as pass (Closes #8170) specs/verified/seal_identity.t27 (#8110) passes in this PR's own t27b-native-ratchet run on the merge ref (UNLISTED 1, all else 0). Rows 1237 -> 1238; not_pass 25 = max_not_pass 25, unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * t27b ledger: carry #8078's rows and cap 24, so the cap line merges clean (Closes #8170) #8078 landed on master: lee_monte_carlo_baseline.t27 blocked -> pass, negative_float_literal.t27 and literal_plan.t27 added as pass, and max_not_pass 26 -> 24. This branch had cap 25, so the cap line conflicted. The same three row edits and the same cap are made here, so the 3-way merge takes them as identical on both sides. A merge commit from master was not used: it would carry master's foreign lines into this branch's pre-commit foreign-budget count. Merged with master 95a68bf (checked with git merge-tree): 1221 rows, unique, sorted, none missing; not_pass 24 = max_not_pass 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * t27b ledger: add speed_quality.t27 and gen_w662.t27 as pass (Closes #8170) Both landed on master without a ledger row (#8182, #8169). Each is t27b pass in its own PR's t27b-native-ratchet run (runs 7a337da and 8a38263). Rows 1240 -> 1242; not_pass 24 = max_not_pass 24, unchanged. theory/warmup.t27 and warmup_t27b.t27 (#8182, also pass) are left for a follow-up: their rows sit next to master's new verilog_aos_memory row (#8154), so adding them here conflicts. Checked with git merge-tree against master b9cf73e: clean, 1224 rows, unique, sorted, none missing, not_pass 24 = cap 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Oct 10, 2026
…w310/314/315/316 helper copies, fixed on master by #8135) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Oct 10, 2026
…w310/314/315/316 helper copies, fixed on master by #8135) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8134
duplicate-bodieswas red on master. The seven ports ofscripts/gen_w310.py..gen_w322.pyeach copied the same six helpers.specs/port/scripts/gen_w_blocks.t27now holds them once, together with the block tests every port repeated. It also addswave_suffix_from(line, i, first)andtransform_block_from(line, first). Every port rewrites three consecutive old waves, so each port now keeps only:Those unchanged tests pin that no port behaves differently. That includes gen_w311's 308..310 crossing of the decade.
t27c test-reportgives gen_w_blocks 9/9 and each port 2/2, with 0 vacuous.python3 tools/dupe_scan.pyexits 0, with 658 copies of 7045 bodies, down from 700.🤖 Generated with Claude Code