Repository navigation
Port gHashTag/trinity:src/storm/experience_engine.zig (Zig, 3 functions) to specs/port/trinity/src/storm/experience_engi - #7052
Merged
Merged
Conversation
…rinity/src/storm/experience_engine.t27 Closes #5833
Rewrites specs/port/trinity/src/storm/experience_engine.t27 so the
generated Zig compiles from .t27 with every function carrying real,
analyzable code - no bare `undefined;` statement anywhere.
Fix for the previous attempt's failure ("value of type
'@typeof(undefined)' ignored"): ExperienceEngine_deinit now resets the
blacklist state (self.blacklist_len = 0) instead of an undefined body.
Probes confirmed this shape generates valid Zig that compiles even when
the function is referenced by a test (pr5 forced-reference zig test:
exit 0).
Design:
- blacklist modeled as fixed-capacity array ([8][]const u8) + count,
the issue's intended structure; t27-style array literals proven to
parse (pr4), Zig-style [_]T{...} literals do not (pr2).
- consult iterates the blacklist through the pointer (for code in
self.blacklist), matches only codes within blacklist_len via string
equality, and returns ConsultResult{.is_blacklisted}.
- init returns the engine directly: the original's error union never
fires (makePath is swallowed). Allocator and makePath are plumbing,
named in the header, not ported.
- no test calls ExperienceEngine_deinit, per the port protocol.
Verified: t27c parse exit 0; typecheck OK (0 errors, 0 warnings);
gen 95 lines, no "not yet implemented", no `undefined`; test-report
4 tests, 4 pass, FAIL 0, no BLOCKED; zig test on generated output
passes plain and with a forced deinit reference; spec-status
IMPLEMENTED.
Closes #5833
A pull request must add exactly one docs/now entry and a bee has no way to know that: its brief names a boundary file and acceptance criteria, and docs/now/ is neither. The publisher adds it rather than failing the gate. Closes #5833 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Oct 6, 2026
Contributor
This was referenced Oct 6, 2026
Merged
This was referenced Oct 6, 2026
Merged
Open
gHashTag
enabled auto-merge (squash)
October 7, 2026 07:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5833
Written by a bee on
queen-5833and published bytools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.🤖 Generated with Claude Code