Skip to content

Wave reports name deliverables that exist in no source file: ExprAddressOf and has_cycle_dfs each live only in the repor - #6757

Merged
github-actions[bot] merged 2 commits into
masterfrom
queen-5406
Oct 6, 2026
Merged

github-actions[bot] merged 2 commits into
masterfrom
queen-5406

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Closes #5406

Written by a bee on queen-5406 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

2 files changed, 4 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 2 commits October 6, 2026 06:01
Erratum (#5406): Add erratum lines to both WAVE_LOOP_51_REPORT.md and WAVE_LOOP_45_REPORT.md documenting deliverables that were claimed as complete but never implemented in source code.

- W51: ExprAddressOf and t27c lint --ascii identifiers absent from source
- W45: has_cycle_dfs identifier absent from source

Closes #5406
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #5406

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-06 12:08:14 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 40
PRs with All Checks Green 10
READY 0
FAILING 40
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 40 + 0 + 0 = 40, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=3c78f3c7ffb7 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 6, 2026
This was referenced Oct 6, 2026

@t27-bees t27-bees Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head 39822371225096e22214c6cdcbaa209fc8b5b19d (tools/bees/reviewer.py, zai glm-4.7-flash, 5 turns, 111 s; then glm-4.5-flash, 5 turns, 158 s).

BEE-VERDICT: APPROVE
summary: Erratum lines correctly added to both reports for identifiers missing from source; original report text preserved; all success criteria met
criterion: FR-001: meets -- evidence: docs/reports/WAVE_LOOP_51_REPORT.md:3; docs/reports/WAVE_LOOP_45_REPORT.md:2
criterion: FR-002: meets -- evidence: diff hunk:18-24 (line 24 added, line 2 exists)
criterion: FR-003: meets -- evidence: no changes to specs/policy/own_language.t27
criterion: Success criterion - grep returns 1 for W51 erratum count -- met -- evidence: brief.md:196
criterion: Success criterion - grep returns 1 for W45 erratum count -- met -- evidence: brief.md:197
criterion: Success criterion - grep returns 1 for ExprAddressOf in W51 -- met -- evidence: brief.md:198
criterion: Success criterion - grep returns 1 for has_cycle_dfs in W45 -- met -- evidence: brief.md:199

Evidence

Based on my analysis of the brief and the diff, here's my evaluation:

Issue Analysis

Issue #5406 Goal: Add erratum lines to wave reports that name deliverables (ExprAddressOf in W51, has_cycle_dfs in W45) that exist only in the report and not in source files.

Acceptance Criteria

  1. FR-001: Each report must gain an Erratum (#5406): line naming absent identifiers

    • W51: ExprAddressOf, t27c lint --ascii
    • W45: has_cycle_dfs
    • ✅ MET — Both reports have the erratum lines
  2. FR-002: Original report text must stay; erratum added, not substituted

    • ✅ MET — Erratum lines are appended after title, original text preserved
  3. FR-003: Must NOT add/modify non-t27 hand-written code (specs/policy/own_language.t27)

    • ✅ MET — No changes to those files; only docs/now/ entry (published by CI, not bee's hand edit)

Success Criteria

All four success criteria are met per runner output:

  • grep -c '^Erratum (#5406):' docs/reports/WAVE_LOOP_51_REPORT.md → 1 ✅
  • grep -c '^Erratum (#5406):' docs/reports/WAVE_LOOP_45_REPORT.md → 1 ✅
  • grep '^Erratum (#5406):' docs/reports/WAVE_LOOP_51_REPORT.md | grep -c ExprAddressOf → 1 ✅
  • grep '^Erratum (#5406):' docs/reports/WAVE_LOOP_45_REPORT.md | grep -c has_cycle_dfs → 1 ✅

Red Checks

None — all non-required checks are green per brief.

Additional Observations

The PR adds a docs/now/2026-10-06-published-wave-reports-name-deliverables-that-exist-in-no-source-file-.md entry. This file documents the PR's published work but does not establish correctness; it's created by the publisher tool, not the bee's hand edit. The content correctly notes that the bee's change names two files (the two reports) and that 2 files changed with 4 insertions.

No hand edits under gen/: Only two report files modified, no generated files.

No deletions of tests: All tests remain.

No weakened assertions: No test assertions modified.

No non-ASCII identifiers: No code changes.

No secrets: No secrets present.

Second, independent review (glm-4.5-flash): APPROVE -- Correctly adds erratum lines to wave reports naming missing deliverables

@t27-bees t27-bees Bot added the bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525) label Oct 6, 2026
@github-actions
github-actions Bot merged commit 1f94b44 into master Oct 6, 2026
25 checks passed
@github-actions
github-actions Bot deleted the queen-5406 branch October 6, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wave reports name deliverables that exist in no source file: ExprAddressOf and has_cycle_dfs each live only in the report announcing them

2 participants