Skip to content

feat(spec): agent-hive-group v3 -- reaction, briefs, deleted topic, summary - #6564

Merged
gHashTag merged 2 commits into
masterfrom
spec/agent-hive-v3
Oct 5, 2026
Merged

feat(spec): agent-hive-group v3 -- reaction, briefs, deleted topic, summary#6564
gHashTag merged 2 commits into
masterfrom
spec/agent-hive-v3

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Closes #6563

Adds the remaining laws from the competitor round of gHashTag/999-multibots-telegraf#3641 to specs/automation/agent-hive-group.t27. The change is additive: v1 and v2 laws are unchanged and VERSION becomes 3.

Law 999 issue
turn_ok / keeps_seen_mark: a refused reaction never fails the turn; a failed turn drops the seen mark #3647
brief_source / brief_fits / may_set_brief: the topic brief wins, at most 1000 chars, set by an admin and never by a bot #3650
recreate_topic: a missing or stale topic is recreated, at most once per 10 min #3652
summary_count: 50 by default, capped by a 200-message log #3653

Verification

  • t27c test-report: 16/16.
  • 8 sed mutants, one per law, all killed. The first pass let two survive: no vector covered stored=false with the thread found, and one sed hit two lines. The missing vector was added and both were re-run on exact lines.
  • Seal refreshed; tri hooks pre-commit PASSED.

🤖 Generated with Claude Code

@gHashTag @claude
feat(spec): agent-hive-group v3 -- reaction, briefs, deleted topic, s…
3de7d58 
…ummary

Closes #6563

Additive laws for gHashTag/999-multibots-telegraf#3647 #3650 #3652 #3653.
16/16 tests; 8 mutants, all killed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-05 17:07:29 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 40
PRs with All Checks Green 10
READY 10
FAILING 40
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=9f2c8a4829f6 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 5, 2026
Merged
Merged
@gHashTag

gHashTag commented Oct 5, 2026

Copy link
Copy Markdown
Owner Author

Reviewer bee: REQUEST_CHANGES. The same account wrote this PR, so GitHub will not take a formal changes-requested review; this comment stands in for one. Do not merge until it is resolved.

Checked independently on head 3de7d58 with t27c test-report: 16/16 pass. Diffed against master: v1/v2 laws are byte-identical; the only removed lines are the old VERSION note, VERSION = 2 and its assert. The laws match #3647, #3650, #3652 and #3653.

Mutants, applied with sed to the PR's spec:

  • brief_fits: <= -> <: killed
  • recreate_topic: >= -> >: killed
  • recreate_topic: drop !stored ||: killed
  • brief_source: topic wins only if there is no group brief: killed
  • keeps_seen_mark: always true: killed
  • may_set_brief: drop && !from_bot: killed
  • summary_count: if asked == 0 -> if asked <= 1: SURVIVED
  • brief_fits: add chars > 0 &&: SURVIVED
  • summary_count: > -> >=: equivalent mutant (200 is capped to 200 either way), so ignored

Defect (blocking): nothing pins the summary_count boundary just above the default sentinel. A host that maps /summary 1 to the default 50 passes every test. Please add assert(summary_count(1) == 1);.

Open question: what does /brief with no text mean? Right now brief_fits(0) is true but no vector says so, so either reading is untested. If an empty brief clears the brief, assert brief_fits(0) and say so in the comment. If it is refused, write that into the law.

The two red checks are not caused by this PR. duplicate-bodies reports the group put, which does not touch this file; dupe_scan.py --like specs/automation/agent-hive-group.t27 says "nothing in this file is written elsewhere", and this workflow is also red on master. spec-guards (ring drift) is red on master as well.

@gHashTag @claude
test(spec): pin summary_count(1) and an empty brief that clears
b90d3f9 
Refs #6563 -- review on #6564: two mutants survived without these vectors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Merged
@gHashTag

gHashTag commented Oct 5, 2026

Copy link
Copy Markdown
Owner Author

Reviewer bee re-review at b90d3f9: sound, approved. GitHub will not take an approving review from the account that wrote the PR, so this comment records the approval.

  • t27c test-report: 16/16 pass. The seal's spec_hash matches the spec at this head (sha256:63ee6ae1...).
  • The two mutants that survived last time are now killed:
    • summary_count: asked == 0 -> asked <= 1 is caught by summary_count(1) == 1.
    • brief_fits: adding chars > 0 && is caught by brief_fits(0).
  • The comment on the law now says that an empty /brief clears the brief.

The duplicate-bodies failure (a body named put, all of it in other specs) and the spec-guards failure (ring drift) were on master before this PR and are still red there. This PR does not cause them. Nothing is bypassed; auto-merge is queued and will wait for the required checks.

@gHashTag gHashTag added the bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525) label Oct 5, 2026
@gHashTag
gHashTag enabled auto-merge (squash) October 5, 2026 17:14
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-05 17:14:51 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 40
PRs with All Checks Green 10
READY 9
FAILING 40
PENDING 0
NO CHECKS YET 0

These columns do not partition: 9 + 40 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=9f2c8a4829f6 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 52abde8 into master Oct 5, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spec: agent-hive-group v3 -- seen/done reaction, standing briefs, deleted topic, /summary

1 participant

@gHashTag