Repository navigation
feat(t27b): tri t27b ready -- the steward's merge gate decided in steward.t27 - #6246
Merged
Merged
Conversation
…ward.t27 check_effect / effect_fold / pr_ready in steward.t27 (80 tests, both compilers). `tri t27b ready [N ...]` prints READY / WAIT / RED / CONFLICT / RETARGET / BLOCKED / CLOSED per PR with the deciding checks; Q16 (a red non-required check blocks only if green on master) is now a tested rule. Master's verdict per check skips cancelled/skipped/neutral runs: counting cancelled made red-here/green-on-master checks look red on master. Closes #6244 Refs #6063 #6198 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
Contributor
This was referenced Oct 4, 2026
…going (Closes #6244) A non-required check red on the PR was judged against master's last verdict even when a newer master run of it was still in progress, so a stale SUCCESS blocked #6249. fold_master now reports PENDING for a run still going on a newer commit, and check_effect (steward.t27) makes such a red check WAIT. 81 tests on t27b and the t27c lab; gen-c byte-equal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks
Contributor
PR DashboardGenerated at: 2026-10-04 20:21:12 UTC
Summary
Seal Status
|
Contributor
PR DashboardGenerated at: 2026-10-04 20:21:29 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6244
Refs #6063 #6198
Stacked on #6242 (its commit is the first one here). Merge #6242 first, and this diff then shrinks to slice 6.
What
specs/tri/t27b/steward.t27gains:check_effect(state, master, required)effect_foldpr_ready(open, mergeable, base_master, required, other), which returns READY, WAIT, RED, CONFLICT, RETARGET, BLOCKED or CLOSEDtri t27b ready [N ...] [--json]prints one line per PR: the verdict and the checks that decided it. Exit 0 only when every listed PR is READY. It never merges.Found while building it
Master's newest runs are often cancelled by the next push. I first counted "cancelled" as master's result. That made five checks that are red on #6206 and green on master look red on master too, so #6206 read READY.
fold_masternow skips cancelled, skipped and neutral runs, and reads 12 master commits back. After the fix, #6206 is BLOCKED byscan(job secret-scan) FAILURE while master'sscanis SUCCESS. Spot-checked by hand withgh pr view.Evidence
t27b test --check: 80/80. t27c labtest-report: 80/80.gen/c/tri/t27b/steward.cwas regenerated on the t27c lab (sha 3161224eea4d).🤖 Generated with Claude Code