Skip to content

EuroCrops V2: the editions a national dataset no longer offers - #344

Open
ivorbosloper wants to merge 4 commits into
mainfrom
eurocrops-v2
Open

ivorbosloper wants to merge 4 commits into
mainfrom
eurocrops-v2

Conversation

@ivorbosloper

@ivorbosloper ivorbosloper commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Adds EuroCropsV2Mixin and an ec_<national id> converter per region for the years only the JRC's EuroCrops V2 (gpqtv202, CC-BY-4.0) still offers. In the catalog they become a backfill of the national collection (fieldsoftheworld/harmonized-field-data-catalog#44).

  • The mixin takes the national converter's HCAT table, supplements, admin codes and whether it publishes crop:name, so the output fits the national collection; it does not inherit the national converter, whose readers are format-specific.
  • Each converter lists only the years the national source lacks: ec_de_bb 2010-2023, ec_be_vlg 2008-2017, ec_be_wal 2015-2021 and 2023, ec_de_nrw 2019-2023, ec_at 2015-2017, ec_es 2021-2023, ec_fr 2015, 2016 and 2018, ec_ee 2015.
  • ec_fr and ec_ee now read V2 instead of EuroCrops V1: one licence per converter, and V2's fr 2018 is the same RPG campaign. ee already has 2021.
  • ec_be_vlg (never published) moves from the V1 2021 file to V2 2008-2017.
  • Rows that are not fields are dropped: Brandenburg's landscape elements (codes 1-5, 10011, 10012) and Flemish buildings (1, 2).
  • Spain's 2023 codes are floats in the source (62.0) and are stripped; Estonia's table is keyed on names, so the code comes from the name, as in ee.

de_bb, de_nrw and be_wal read new supplement tables for the codes their national tables miss (fiboa/fiboa.github.io#33); the fixtures carry copies until that is deployed.

Two fixes found while building the national collections: de_nrw now reads the INSPIRE id the extension it declares requires, and ee leaves out parcels that declare no crop.

🤖 Generated with Claude Code

EuroCropsV2Mixin converts the JRC's EuroCrops V2 files so they fit the national
collection: the national crop table, admin codes and crop columns, the JRC as
source. ec_de_bb, ec_be_vlg, ec_be_wal, ec_de_nrw, ec_at and ec_es are new or
moved onto it; ec_fr and ec_ee read EuroCrops V2 instead of V1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread tests/data-files/convert/ec_fr/fr_2018.csv

This comment was marked as resolved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Production supplement availability and source compatibility across historical editions still require human verification.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants