Skip to content

fix: match build watch ignore by path segment #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AyobamiH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: match build watch ignore by path segment #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/watch/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const path = require('node:path')

const arrayToRegExp = (arr) => {
const reg = arr.map((file) => {
if (file === 'build') { return '(?:^|[/\\\\])build(?:[/\\\\]|$)' }
if (/^\./.test(file)) { return `\\${file}` }
return file
}).join('|')
Expand Down
14 changes: 13 additions & 1 deletion test/watch.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,20 @@ test('followWatch parameter should set watchDir correctly', async (t) => {
test('should equal expect RegExp', t => {
t.plan(1)

const expectRegExp = /(node_modules|build|dist|\.git|bower_components|logs)/
const expectRegExp = /(node_modules|(?:^|[/\\])build(?:[/\\]|$)|dist|\.git|bower_components|logs)/
const regExp = arrayToRegExp(['node_modules', 'build', 'dist', '.git', 'bower_components', 'logs'])

t.assert.deepStrictEqual(regExp, expectRegExp)
})

test('build ignore should only match build path segments', t => {
const regExp = arrayToRegExp(['build'])

t.assert.strictEqual(regExp.test('/tmp/any-builder/app.js'), false)
t.assert.strictEqual(regExp.test('/tmp/builders/app.js'), false)
t.assert.strictEqual(regExp.test('C:\\work\\any-builder\\app.js'), false)

t.assert.strictEqual(regExp.test('build/app.js'), true)
t.assert.strictEqual(regExp.test('/tmp/any-builder/build/app.js'), true)
t.assert.strictEqual(regExp.test('C:\\work\\any-builder\\build\\app.js'), true)
})