Conversation
Signed-off-by: Ayobami Haastrup <47716486+AyobamiH@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #717.
The watcher currently compiles the default ignore entries into a single regular expression. Because
buildis included as an unbounded alternative, it matches the substring anywhere in a watched path. This causes projects with names such asany-builder, as well as directories such asbuilders, to be ignored.This change treats the literal
buildignore entry as a path segment instead.With this change:
build/app.jsremains ignoredsrc/build/app.jsremains ignoredbuilddirectory paths remain ignoredany-builder/app.jsis watchedbuilders/app.jsis watchedThe change is deliberately limited to the
buildtoken. Existing custom--ignore-watchexpressions retain their current behaviour.Regression coverage includes both POSIX and Windows path separators.
Checklist
npm run test && npm run benchmark --if-presentDocumentation is not changed because this fixes the matching semantics of an existing documented default rather than changing the CLI interface or its documented default value.