Skip to content

deps: qs@~6.16.0 - #761

Merged
Phillip9587 merged 1 commit into
expressjs:1.xfrom
krzysdz:1.x-update-qs.6.16
Sep 2, 2026
Merged

deps: qs@~6.16.0#761
Phillip9587 merged 1 commit into
expressjs:1.xfrom
krzysdz:1.x-update-qs.6.16

Conversation

@krzysdz

@krzysdz krzysdz commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

The 6.16.0 release of qs patches 2 vulnerabilities, neither of which affects body-parser:

@Phillip9587 Phillip9587 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Phillip9587

Copy link
Copy Markdown
Member

@krzysdz Can you please also create a PR for master?

@krzysdz

krzysdz commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

The 2.x version uses ^6.15.2, so the version bump is not necessary, but I will do it.

EDIT: #762

This was referenced Sep 1, 2026
@Phillip9587
Phillip9587 merged commit 355eb04 into expressjs:1.x Sep 2, 2026
35 checks passed
@Phillip9587

Copy link
Copy Markdown
Member

Hey @UlisesGascon we would need your help to get this security 1.x release out.

@krzysdz
krzysdz deleted the 1.x-update-qs.6.16 branch September 2, 2026 12:40
matz3 added a commit to SAP/ui5-cli that referenced this pull request Sep 7, 2026
Consumers who installed @ui5/cli and ran "npm ci" got:

  npm error Missing: qs@6.15.3 from lock file

The "overrides" entry forced a single qs@6.16.0 across the bundled
express/body-parser tree at pack time. Overrides are producer-only, so
consumers re-resolve without them, expect qs@6.15.3, and the lockfile no
longer matches, breaking "npm ci".

The GHSA-x5fp-wj9c-mxmx / GHSA-4mjr-xmp4-gh2g qs vulnerability that the
override addressed is not applicable to the way express / body-parser use
qs, so removing the override does not expose us to it.

Upstream fixes are in progress but not yet consumable: the qs bumps are
still open pull requests, not merged or released, so we cannot rely on the
transitive dependencies alone yet:

  expressjs/express#7440
  expressjs/body-parser#761

Dropping the override lets qs resolve naturally and keeps package.json and
package-lock.json in sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants