[FIX] Remove qs overrides from package.json - #868
Merged
Conversation
Consumers who installed @ui5/cli and ran "npm ci" got: npm error Missing: qs@6.15.3 from lock file The "overrides" entry forced a single qs@6.16.0 across the bundled express/body-parser tree at pack time. Overrides are producer-only, so consumers re-resolve without them, expect qs@6.15.3, and the lockfile no longer matches, breaking "npm ci". The GHSA-x5fp-wj9c-mxmx / GHSA-4mjr-xmp4-gh2g qs vulnerability that the override addressed is not applicable to the way express / body-parser use qs, so removing the override does not expose us to it. Upstream fixes are in progress but not yet consumable: the qs bumps are still open pull requests, not merged or released, so we cannot rely on the transitive dependencies alone yet: expressjs/express#7440 expressjs/body-parser#761 Dropping the override lets qs resolve naturally and keeps package.json and package-lock.json in sync.
flovogt
approved these changes
Sep 7, 2026
matz3
added a commit
to UI5/cli
that referenced
this pull request
Sep 7, 2026
This repo just brings all @ui5/ packages together and runs our audit scan. Since our published packages don't define this override, we shouldn't add one here either — otherwise the audit would run against a dependency tree that differs from what we actually ship. The "qs" vulnerability (GHSA-x5fp-wj9c-mxmx / GHSA-4mjr-xmp4-gh2g) is not applicable to the way express / body-parser use qs, so the override is not needed. Follows SAP/ui5-cli#868.
matz3
added a commit
to UI5/cli
that referenced
this pull request
Sep 7, 2026
This repo just brings all @ui5/ packages together and runs our audit scan. Since our published packages don't define this override, we shouldn't add one here either — otherwise the audit would run against a dependency tree that differs from what we actually ship. The "qs" vulnerability (GHSA-x5fp-wj9c-mxmx / GHSA-4mjr-xmp4-gh2g) is not applicable to the way express / body-parser use qs, so the override is not needed. Follows SAP/ui5-cli#868.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers who installed @ui5/cli and ran "npm ci" got:
npm error Missing: qs@6.15.3 from lock fileThe "overrides" entry forced a single qs@6.16.0 across the bundled express/body-parser tree at pack time. Overrides are producer-only, so consumers re-resolve without them, expect qs@6.15.3, and the lockfile no longer matches, breaking "npm ci".
The GHSA-x5fp-wj9c-mxmx / GHSA-4mjr-xmp4-gh2g qs vulnerability that the override addressed is not applicable to the way express / body-parser use qs, so removing the override does not expose us to it.
Upstream fixes are in progress but not yet consumable: the qs bumps are still open pull requests, not merged or released, so we cannot rely on the transitive dependencies alone yet:
expressjs/express#7440
expressjs/body-parser#761
Dropping the override lets qs resolve naturally and keeps package.json and package-lock.json in sync.