Harden caller snippet for Sonar quality gate - #6
Merged
Conversation
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented caller failed SonarQube Cloud's quality gate on every analysed repo, dropping the security rating to C: two rules fire, one for the unpinned workflow ref and one for
secrets: inherit. Verified on evolution-gaming/skafka#607, green once both are fixed.secrets: inheritwas never needed; the Coveralls upload uses the automaticGITHUB_TOKEN. SONAR_TOKEN is now a declared optional secret so the scan can still be wired up explicitly.Part of #5