Skip to content

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

44 Commits
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Scala GitHub Actions

Scala CI workflow

Runs tests, coverage, binary compatibility, formatting and Scaladoc on every push and pull request. Replaces the handwritten ci.yml that each project used to carry.

Setup

Create .github/workflows/ci.yml:

name: CI

on:
  push:
    branches: [ master ]
  pull_request:

jobs:
  test:
    uses: evolution-gaming/scala-github-actions/.github/workflows/ci.yml@<sha> # v6.2.0

Nothing else is required if the project uses the defaults below.

Two things about that snippet are deliberate, both because SonarQube Cloud's quality gate rejects the alternatives and drops the security rating to C:

  • the workflow is pinned to a full commit SHA, with the tag in a trailing comment. The snippet writes it as <sha> on purpose, so this README cannot go stale every time v6 moves. Resolve the current value with:

    gh api repos/evolution-gaming/scala-github-actions/git/tags/$(
      gh api repos/evolution-gaming/scala-github-actions/git/ref/tags/v6 --jq .object.sha
    ) --jq .object.sha
  • there is no secrets: inherit. It is not needed — GITHUB_TOKEN is available to a called workflow automatically, and that is what the Coveralls upload uses. Only the optional Sonar scan needs a secret.

Inputs

input default notes
scala_versions '["2.13.18", "3.3.8"]' JSON array; becomes the build matrix
java_version '17'
java_distribution 'temurin'
test_task auto testFull on sbt 2, test on sbt 1, read from project/build.properties
coverage true collect coverage and upload to Coveralls
version_policy_check true requires sbt-version-policy
scalafmt_check true
doc_check true runs Compile/doc
sonar false run a SonarQube Cloud scan, see below
sonar_project_key <owner>_<repo>
sonar_args '' extra -D arguments for the scanner

Example for a project without sbt-version-policy and on a different Scala set:

jobs:
  test:
    uses: evolution-gaming/scala-github-actions/.github/workflows/ci.yml@<sha> # v6.2.0
    with:
      scala_versions: '["2.13.18", "3.3.7"]'
      version_policy_check: false

Why the steps are ordered this way

Two sbt 2 behaviours make a naive coverage setup report nothing while still passing:

  • sbt 2's compile cache is not keyed on scoverage's instrumentation. If a plain compile runs first, the coverage build reuses those uninstrumented classes and the report comes out empty. The coverage build therefore runs before the formatting, binary-compatibility and scaladoc checks.
  • sbt/setup-sbt restores ~/.cache/sbt across runs by default, which reintroduces the same problem on any run whose build files did not change. This workflow sets disk-cache: false whenever coverage is enabled.

The workflow also fails if the produced Cobertura report has no valid lines, so a silently empty report is an error rather than a green build.

Binary compatibility, formatting and Scaladoc run as explicit sbt tasks, not via a project-local check alias. An alias can be stubbed out (addCommandAlias("check", "show version")), which makes the gate silently guarantee nothing.

The workflow checks out with fetch-depth: 0. Without tags sbt-dynver reports the version as 0.0.0, versionPolicyCheck then has no previous version to compare against, and the binary compatibility check passes without checking anything.

SonarQube Cloud

Most repositories should not use the sonar input. Analysis is done server-side by SonarQube Cloud's Automatic Analysis, which needs no token, no CI step and no repository configuration — that is how kafka-journal and the other analysed repositories work. The sonar input exists for the CI-based scanner, which is the mutually exclusive alternative.

If you do enable it, it scans once, on the first Scala version, importing scoverage's per-module reports. Configuration is passed as scanner arguments, so no per-repo sonar-project.properties is needed.

Three prerequisites, all outside this repo:

  1. A SONAR_TOKEN organization secret. It does not exist yet, so sonar: true will fail until it is added.
  2. The project must already exist on SonarQube Cloud — the scanner reports to a project, it does not create one.
  3. Automatic Analysis must be turned off for that project. It and CI-based scanning are mutually exclusive, and Automatic Analysis wins, so the scan will be rejected while it is on.

The scanner also needs the token passed through, which the caller must do explicitly now that secrets: inherit is gone:

    secrets:
      SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

Note that the SonarQube Cloud GitHub App creates a check suite on every commit even in repositories it never analyses, which leaves a check permanently queued and reporting no result. Repositories not being analysed should have the app removed rather than left in that state.

Scala Release workflow (v3, v4, v5)

Setup

To use Scala Release workflow have to set up project:

  • add latest sbt-dynver plugin
  • add Evolution's artifactory plugin sbt-artifactory-plugin
  • defined command alias check which runs code quality checks, for example: scalafmt and scalafix, and binary compatibility check by sbt-version-policy:
    addCommandAlias("fmt", "all scalafmtAll scalafmtSbt; scalafixEnable; scalafixAll") // optional: for development
    addCommandAlias("check", "all versionPolicyCheck Compile/doc scalafmtCheckAll scalafmtSbtCheck; scalafixEnable; scalafixAll --check")
    addCommandAlias("build", "all compile test") // optional: for development
    as very minimum "no-op" placeholder:
    addCommandAlias("check", "show version")
  • direct publishTo to Evolution's artifactory (for publishing artifacts using sbt-artifactory-plugin):
    publishTo := Some(Resolver.evolutionReleases)
  • create release.yml file with content:
      name: Publish Release
      
      on:
        push:
          tags:
            - 'v*'
      
      jobs:
        release:
          uses: evolution-gaming/scala-github-actions/.github/workflows/release.yml@v5
          secrets: inherit

Usage

In project's repo:

  • push tag as separate activity
  • crate new version tag, like git tag v1.2.3 -a -m "release v1.2.3"
  • push the tag, git push origin tag v1.2.3

The above sequence will start Release workflow, which will:

  • run SBT commands +clean; +check; +all test package to verify the build
  • run SBT command +publish to publish packaged artifacts
  • if any of above steps will fail, the workflow will remove git tag - improve code and push fix, later tag again
  • workflow will auto-generate release notes and will publish them
  • go to Code and navigate to Releases
  • review release notes and amend, if required

The v4 version additionally allows overriding SBT commands used by the release job. It is especially useful for projects which have mixed Scala versions in submodules and for which the +, +all SBT features might not work properly:

jobs:
  release:
    uses: evolution-gaming/scala-github-actions/.github/workflows/release.yml@v4
    secrets: inherit
    with:
      # override sbt commands so they don't use "+" because the project uses mixed Scala versions with sbt-projectmatrix
      verify_sbt_command: 'clean; check; all test package'
      publish_sbt_command: 'publish'

Scala Release workflow (v2)

Replaced by v3 because GitHub excluded SBT from ubuntu-latest (details).

Scala Release workflow (v1)

Setup

To use Scala Release workflow have to set up project:

  • add latest sbt-release plugin
  • add Evolution's artifactory plugin sbt-artifactory-plugin
  • defined command alias check which runs code quality checks, for example: scalafmt and scalafix, and binary compatibility check by sbt-version-policy:
    addCommandAlias("fmt", "all scalafmtAll scalafmtSbt; scalafixEnable; scalafixAll") // optional: for development
    addCommandAlias("check", "all versionPolicyCheck Compile/doc scalafmtCheckAll scalafmtSbtCheck; scalafixEnable; scalafixAll --check")
    addCommandAlias("build", "all compile test") // optional: for development
    as very minimum "no-op" placeholder:
    addCommandAlias("check", "show version")
  • direct publishTo to Evolution's artifactory (for sbt-release using sbt-artifactory-plugin):
    publishTo := Some(Resolver.evolutionReleases)
  • create release.yml file with content:
      name: Publish Release
      
      on:
        release:
          types: [published]
          branches: [main]
      
      jobs:
        release:
          uses: evolution-gaming/scala-github-actions/.github/workflows/release.yml@v1
          secrets: inherit

Usage

On GitHub:

  • go to Releases page
  • press Draft a new release button
  • make sure that version.sbt file in root of project have correct version string, like 1.2.3
  • in Choose a tag create a new tag (v1.2.3)
  • set Release title to the same string (v1.2.3)
  • press Generate release notes and review them
  • press Publish release button
  • navigate to Actions - there it is possible to follow build's progress

The above sequence will start Release workflow, which will:

  • validate consistency of git tag and version
  • run SBT commands clean; +all check test package to make sure that code quality is good
  • run SBT command +publish to publish packaged artifacts
  • if any of above steps will fail, the workflow will remove git tag and GitHub will mark release notes as draft and it will be possible to adjust code on main branch and attempt publishing again by navigating to drafted release and pressing Publish release button again

When release is published, make sure to amend version.sbt file with next version string.

Recommended Scala project setup

scalafmt

Minimal configuration requires usage of plugin like:

addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "<latest version>")

scalafix

Minimal configuration requires usage of plugin like:

addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "<latest version>")

binary compatibility

Requires usage of sbt-version-policy plugin like:

addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "<latest version>")

scalac options

Evolution's plugin with very strict settings for Scala 2.12 and 2.13 projects

addSbtPlugin("com.evolution" % "sbt-scalac-opts-plugin" % "<latest version>")

About

No description, website, or topics provided.

Resources

Contributing

Stars

1 star

Watchers

2 watching

Forks

Releases

Packages

Used by

Contributors