Repository navigation
Conversation
|
🚀 env0 had composed a PR Plan for environment ACME Financial Services / Demos / Plugins Demo / env0-import-variable-plugin test : |
erezrokah
marked this pull request as ready for review
October 22, 2026 08:03
erezrokah
changed the title
erezrokah
changed the title
dcelasun
approved these changes
Oct 22, 2026
dcelasun
left a comment
dcelasun
left a comment
There was a problem hiding this comment.
@erezrokah LGTM, covers all four points from #19. Nits:
test/env0.yaml:9: the sed → bash pipeline has nopipefailor empty-output check, so a missing file means the step runs nothing and still passes.- PR plans still download 0.5.1's binary and
importVariables.sh, so PR changes tomain.goor the script aren't exercised. - The README pin check added in d85154e was removed in e1c2b35, and the
@0.5.1pin will go stale. Intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a pinned
@0.5.1version in the README example, make the env0 test flow run the plugin script from the PR itself instead ofmain, and add curl connect and total timeouts so a blocked download falls back to the source build quickly.