Skip to content

feat(ui): add customizable keyboard shortcuts manager and dialog - #66

Open
Kyuzan0 wants to merge 1 commit into
enowdev:mainfrom
Kyuzan0:feat/shortcuts-manager
Open

Kyuzan0 wants to merge 1 commit into
enowdev:mainfrom
Kyuzan0:feat/shortcuts-manager

Conversation

@Kyuzan0

@Kyuzan0 Kyuzan0 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds customizable keyboard shortcuts manager addressing maintainer review feedback:

  • Requires modifier keys in ParseKey (disallows bare letter bindings).
  • Protects reserved terminal keys (e.g. Ctrl+C) and rejects key conflicts.
  • Retains floating control and Cmd-click informational rows in Settings.
  • Adds confirmation dialog before "Reset all to defaults".
  • Resolved staticcheck SA4006 in tests.
  • Documents shortcuts manager in docs/settings.md.

Verification

  • Passed go test -v ./ui -run "TestParseAndFormatKey|TestAppShortcutsConfigAndState|TestShortcutStateJSONPersistence|TestShortcutDialogUI"
  • Clean gofmt -l

- Add customizable keyboard shortcuts with modifier key requirements
- Refuse conflicting shortcuts and protect terminal control keys (Ctrl+C)
- Preserve floating control and Cmd-click informational rows in Settings
- Add confirmation dialog before resetting all shortcuts to defaults
- Fix staticcheck SA4006 and format with gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant