Repository navigation
Conversation
enowdev
requested changes
Nov 10, 2026
enowdev
left a comment
Owner
There was a problem hiding this comment.
Thanks for this, there's a lot of good work here. It bundles four unrelated changes, though, and two of them change behaviour for everyone, so could you split it into separate PRs: the Antigravity preset, the Fluent style, the window controls switch, and the shortcuts manager? Here's what we'd need in each.
Antigravity preset
- The preset itself (
--continue/--conversation,core/agent/presets.go:190-191) looks good. - In
AntigravityFiles, please drop the fallback that scans all ofbrain/(core/transcript/antigravity.go:51-67). It returns other projects' conversations, so a session can show the wrong chat. Only return conversations whose workspace matches the session's folder. - Please keep the continue fix narrow.
comesBack(daemon/session_wake.go:80),restore(daemon/persist.go:269-274) andresumeSessionIn(daemon/persist.go:443-448) now relaunch every agent with a continue flag. If the problem is Antigravity sessions created before the preset had--continue, a targeted fix for those would be safer. - We'd rather not have
enowx continuewithout an ID pick a session by itself (cli/control.go:235-251). Agents call this command too. core/recoveryisn't used anywhere, and its session IDs are UUIDs (core/recovery/engine.go:57) while ours aren't. Please leave it out: killing a process by a stored PID (core/recovery/engine.go:126) and rewriting an agent's transcript (core/recovery/compact.go:73-117) are things we'd want to design together first.- The
docs/proposalsfiles are about OMP and not in English; please drop them.
Windows 11 style
- Please keep
widget.Button/Input/SearchField/Triggeron their current radius for the existing styles (ui/widget/controls.go). Moving them toRadiusControlturns every pill into a 16 px rounded rectangle in the default style (ui/theme/style.go:46). - The same goes for the inset border on secondary buttons where
Rule > 0. - Let the Windows 11 style carry its own values instead of
Wellchecking the style ID"windows-11". - The CSS-variable generator and
ToMaparen't used (ui/theme/fluent_tokens.go:173-267); please remove them.
Window controls
- Fine as is apart from gofmt on
ui/windowbuttons.goandui/windowbuttons_test.go.
Shortcuts manager
- Please require a modifier, so a bare letter can't be bound and take typing (
ParseKey,ui/shortcuts.go:190-246). - Refuse conflicts rather than only warning about them (
setShortcutKey,ui/shortcuts.go:384-400), and include keys the terminal needs (Ctrl+C on Windows and Linux). - Keep the floating control and Cmd-click rows in Settings' shortcut list; they were dropped with
shortcutList. - Ask before "Reset all to defaults".
- The macOS CI failure is staticcheck SA4006 at
ui/shortcuts_test.go:130.
Each new feature should also have a short entry in the docs (agents, settings). Happy to review each part as it comes in.
- Add Continue (--continue) and Resume (--conversation) flags to Antigravity preset - Add Antigravity transcript reader and test coverage - Add targeted continue restore fallback for Antigravity sessions - Update docs/agents.md reference table
Kyuzan0
force-pushed
the
feat/antigravity-continue-and-fluent-theme
branch
from
November 17, 2026 10:38
ac44a03 to
3f12ad6
Compare
Contributor
Author
|
Hi @enowdev, As requested in the review, I have split the changes into 4 clean, focused PRs addressing all the review points:
Thank you for the guidance and review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class preset support and transcript reading for Google Deepmind's Antigravity agent CLI:
Continue: []string{--continue}andResume: []string{--conversation}tocore/agent/presets.go.AntigravityFilesreader discovering matching workspace sessions viahistory.jsonlincore/transcript/antigravity.gowith full test coverage (removed fallback directory scanning).r.Agent == antigravityindaemon/persist.go.docs/agents.mdpreset reference table.Verification
go test ./core/agent ./core/transcript