Skip to content

Use if-let* / when-let* instead of the obsolete plain forms #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonuexe merged 1 commit into from
Jul 17, 2026
Merged

Use if-let* / when-let* instead of the obsolete plain forms #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpstan-hover.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@
"Return hover type string at point.

If PREFER-PHPDOC is non-nil, return PHPDoc type when available."
(when-let ((datum (phpstan-hover--datum-at-point)))
(when-let* ((datum (phpstan-hover--datum-at-point)))
(let ((type (plist-get datum :typeDescr))
(phpdoc-type (plist-get datum :phpDocType)))
(if (and prefer-phpdoc
Expand Down Expand Up @@ -332,7 +332,7 @@ This honors `phpstan-hover-display-backend'."

(defun phpstan-hover--show-at-point ()
"Show hover text for current point if available."
(if-let ((datum (phpstan-hover--datum-at-point)))
(if-let* ((datum (phpstan-hover--datum-at-point)))
(phpstan-hover--show (phpstan-hover--format-message datum))
(setq phpstan-hover--last-shown nil)
(phpstan-hover--hide)))
Expand Down
2 changes: 1 addition & 1 deletion phpstan.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ it returns the value of `SOURCE' as it is."
(defun phpstan-find-baseline-file ()
"Find PHPStan baseline file of current project."
(interactive)
(if-let ((path (locate-dominating-file default-directory phpstan-baseline-file)))
(if-let* ((path (locate-dominating-file default-directory phpstan-baseline-file)))
(find-file (expand-file-name phpstan-baseline-file path))
(user-error "Baseline file not found. Try running M-x phpstan-generate-baseline")))

Expand Down
Loading