Use if-let* / when-let* instead of the obsolete plain forms - #68
Merged
Conversation
`if-let' and `when-let' are obsolete as of Emacs 31.1, and the byte compiler warns about all three uses here. Each binds a single value, so the starred forms are a direct, behaviour-preserving replacement. Both are available on the supported Emacs (27.1+) through subr-x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if-letandwhen-letare obsolete as of Emacs 31.1, and the byte compiler warns about all three uses (phpstan.el:483, phpstan-hover.el:246 and :335). Each binds a single value, so the starred forms are a direct, behaviour-preserving replacement. Both are available on the supported Emacs (27.1+) through subr-x — verified by loading the sources uncompiled on Emacs 27.2 and exercising theif-let*path.Compilation is now warning-free on Emacs 27.2 and current master Emacs; the test suite still passes (15/15).