Skip to content

build: bump @electron/lint-roller to ^4.0.0 - #1224

Draft
claude[bot] wants to merge 2 commits into
mainfrom
lint-roller-4
Draft

claude[bot] wants to merge 2 commits into
mainfrom
lint-roller-4

Conversation

@claude

@claude claude Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Requested by David Sanders · Slack thread

Description of Change

Before: @electron/lint-roller was pinned at ^3.3.0, and check-blog-links.yml invoked lint-roller-markdown-links with the --fetch-external-links flag.

After: @electron/lint-roller is ^4.0.0 (lockfile resolves to 4.0.0), and the --fetch-external-links flag, removed in 4.0.0, is dropped from the check-blog-links.yml invocation. No package.json scripts changed.

Notes

  • 4.0.0 breaking changes that touch this repo:
    • lint-roller-markdown-links dropped --fetch-external-links and --check-redirects. Only --fetch-external-links was used here (.github/workflows/check-blog-links.yml). With it removed, that workflow now validates only internal/relative links and anchors in changed blog posts, not that external URLs resolve.
    • lint-roller-markdown-standard was removed; this repo never used it (markdown lints via markdownlint-cli2 extending @electron/lint-roller/configs/markdownlint.json and its custom rules, both unchanged).
    • Node floor is now ^22.17.0 || >=24.0.0. engines.node is 24, .nvmrc is 24.19.0, and every workflow uses .nvmrc or 24.19.0, so no CI change needed.
  • Peer warning on install: oxlint is listed by your project with version 1.57.0, which doesn't satisfy what @electron/lint-roller requests (>=1.65.0). It is only relevant to the new lint-roller-markdown-oxlint bin, which this repo does not use. oxfmt ^0.42.0 already satisfies the >=0.20.0 peer.
  • Tests: yarn lint passes (tsc, oxfmt --check, oxlint, markdownlint-cli2 on 140 files, 0 errors). The migrated lint-roller-markdown-links --ignore-path .markdownlintignore --allow-absolute-links --resource-root static invocation runs clean locally against recent blog posts; the old flag is rejected by 4.0.0 with a usage error.
  • Lockfile delta: yarn.lock +53 / -1332 (the ESLint/standard dependency tree is gone).
  • Open questions: should oxlint be bumped to ^1.65.0 to clear the peer warning, and does check-blog-links.yml need a replacement for external-link fetching?

Checklist

🤖 Generated with Claude Code

https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV


Generated by Claude Code

Drop the removed --fetch-external-links flag from the
lint-roller-markdown-links call in check-blog-links.yml.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
@socket-security

socket-security Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​electron/​lint-roller@​3.3.0 ⏵ 4.0.093 +910092 +690 +8100

View full report

@socket-security

socket-security Bot commented Sep 19, 2026

Copy link
Copy Markdown

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
Recently published: npm @electron/lint-roller published yesterday

Location: Package overview

From: package.jsonnpm/@electron/lint-roller@4.0.0

ℹ Read more on: This package | This alert | What are recently published artifacts?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should either be allowlisted to allow recently-published versions, or an older version should be used instead.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@electron/lint-roller@4.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 19, 2026

Copy link
Copy Markdown

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 99eb49d
Status: ✅  Deploy successful!
Preview URL: https://10d2dde2.electron-website.pages.dev
Branch Preview URL: https://lint-roller-4.electron-website.pages.dev

View logs

Use xargs -r so lint-roller-markdown-links is not invoked with no files
when a PR only removes posts. Ported from #1226.

Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant