build: bump @electron/lint-roller to ^4.0.0 - #1224
claude[bot] wants to merge 2 commits into
Conversation
Drop the removed --fetch-external-links flag from the lint-roller-markdown-links call in check-blog-links.yml. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
Deploying electron-website with
|
| Latest commit: |
99eb49d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10d2dde2.electron-website.pages.dev |
| Branch Preview URL: | https://lint-roller-4.electron-website.pages.dev |
Use xargs -r so lint-roller-markdown-links is not invoked with no files when a PR only removes posts. Ported from #1226. Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
Requested by David Sanders · Slack thread
Description of Change
Before:
@electron/lint-rollerwas pinned at^3.3.0, andcheck-blog-links.ymlinvokedlint-roller-markdown-linkswith the--fetch-external-linksflag.After:
@electron/lint-rolleris^4.0.0(lockfile resolves to 4.0.0), and the--fetch-external-linksflag, removed in 4.0.0, is dropped from thecheck-blog-links.ymlinvocation. Nopackage.jsonscripts changed.Notes
lint-roller-markdown-linksdropped--fetch-external-linksand--check-redirects. Only--fetch-external-linkswas used here (.github/workflows/check-blog-links.yml). With it removed, that workflow now validates only internal/relative links and anchors in changed blog posts, not that external URLs resolve.lint-roller-markdown-standardwas removed; this repo never used it (markdown lints viamarkdownlint-cli2extending@electron/lint-roller/configs/markdownlint.jsonand its custom rules, both unchanged).^22.17.0 || >=24.0.0.engines.nodeis24,.nvmrcis24.19.0, and every workflow uses.nvmrcor24.19.0, so no CI change needed.oxlint is listed by your project with version 1.57.0, which doesn't satisfy what @electron/lint-roller requests (>=1.65.0). It is only relevant to the newlint-roller-markdown-oxlintbin, which this repo does not use.oxfmt ^0.42.0already satisfies the>=0.20.0peer.yarn lintpasses (tsc,oxfmt --check,oxlint,markdownlint-cli2on 140 files, 0 errors). The migratedlint-roller-markdown-links --ignore-path .markdownlintignore --allow-absolute-links --resource-root staticinvocation runs clean locally against recent blog posts; the old flag is rejected by 4.0.0 with a usage error.yarn.lock+53 / -1332 (the ESLint/standard dependency tree is gone).oxlintbe bumped to^1.65.0to clear the peer warning, and doescheck-blog-links.ymlneed a replacement for external-link fetching?Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
Generated by Claude Code