build: update @electron/lint-roller to 4.0.0 - #1226
Closed
MarshallOfSound wants to merge 2 commits into
Closed
MarshallOfSound wants to merge 2 commits into
MarshallOfSound wants to merge 2 commits into
Conversation
lint-roller 4 drops the eslint/standard dependency tree and no longer offers external link fetching in lint-roller-markdown-links, so the blog post link check keeps validating relative links and static resources without that option.
With no filenames on stdin, xargs still ran lint-roller-markdown-links once with no globs, which prints usage and fails the job.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Deploying electron-website with
|
| Latest commit: |
13ad0d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a29d9f8.electron-website.pages.dev |
| Branch Preview URL: | https://claude-lint-roller-4.electron-website.pages.dev |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
Author
|
@SocketSecurity ignore npm/@electron/lint-roller@4.0.0 |
claude Bot
pushed a commit
that referenced
this pull request
Sep 20, 2026
Use xargs -r so lint-roller-markdown-links is not invoked with no files when a PR only removes posts. Ported from #1226. Co-Authored-By: Samuel Attard <MarshallOfSound@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MpGBviMFFyBDsWe7wfW3eV
Contributor
|
Closing in favor of #1224, which has the same bump and now also carries the Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Bumps
@electron/lint-rollerto 4.0.0, which drops the transitive eslint/standard dependency tree; the shared markdownlint config and custom rules this repo uses are unchanged.lint-roller-markdown-linksno longer has a--fetch-external-linksmode (electron/lint-roller#203, too many sites block automated fetches), socheck-blog-links.ymldrops that flag and keeps validating relative links andstatic/resources in new blog posts. While there, the step now usesxargs -rso a PR that only removes posts doesn't run the linter with no files and fail on its usage message.oxlint stays at ^1.57.0: lint-roller 4 lists
oxlint >= 1.65as a peer for its newlint-roller-markdown-oxlintcommand, which this repo doesn't use, and a newer oxlint flags a handful of React findings insrc/that are better handled separately. Expect a peer warning on install until then.Checklist
Generated by Claude Code