Keep project plugin installs additive across config layers - #592
Merged
Conversation
zikajk
force-pushed
the
fix/additive-plugin-installs
branch
6 times, most recently
from
September 10, 2026 13:51
efbca82 to
9c7ed8c
Compare
zikajk
marked this pull request as ready for review
September 10, 2026 14:38
zikajk
force-pushed
the
fix/additive-plugin-installs
branch
4 times, most recently
from
September 10, 2026 15:09
350ee43 to
08a35dc
Compare
Preserve inherited plugins when a project adds its own, with an explicit installMode replacement option for users who need the previous behavior. Limit uninstall to global declarations so inherited plugins are not reported as removed when they remain active.
zikajk
force-pushed
the
fix/additive-plugin-installs
branch
from
September 10, 2026 15:11
08a35dc to
93c085e
Compare
ericdallo
approved these changes
Sep 10, 2026
ericdallo
left a comment
ericdallo
left a comment
Member
There was a problem hiding this comment.
Yeah I was aware of this gap, this looks good, and the default makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins.installacross config layers, preserving source definitions and later-plugin precedence. Other config arrays keep their current behavior.plugins.installMode: "replace"to preserve the previous exclusion behavior, including an empty list.Compatibility
This changes the default: global plugins previously hidden by a project install list will now load, including their hooks and tools. Users who relied on exclusion must set
installMode: "replace"beside that list. Existing direct hook definitions are unchanged.Verification
🤖 Generated with ECA (openai/gpt-6-astra - medium)