Preserve pre-tool hook feedback in model history - #593
Closed
zikajk wants to merge 1 commit into
Closed
Conversation
Successful preToolCall warnings were visible in the UI but absent from model context. Append them to the matching tool result after post hooks so output replacement cannot erase them, without duplicating denials.
Member
Author
|
Closing as out of scope for the brepl integration. Pre-tool hooks will continue to adjust or reject input; post-tool hooks will report repairs and evaluation results. The existing updatedInput behavior is sufficient, so this general pre-hook context-delivery extension is not needed. PR #592 is separate and unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preToolCall.additionalContextwith the matching tool result, rather than showing warnings only in the UI. ExistingupdatedInputbehavior is unchanged.Verification
🤖 Generated with ECA (openai/gpt-6-astra)