Skip to content

Preserve pre-tool hook feedback in model history - #593

Closed
zikajk wants to merge 1 commit into
masterfrom
fix/hook-feedback
Closed

Preserve pre-tool hook feedback in model history#593
zikajk wants to merge 1 commit into
masterfrom
fix/hook-feedback

Conversation

@zikajk

@zikajk zikajk commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Deliver successful preToolCall.additionalContext with the matching tool result, rather than showing warnings only in the UI. Existing updatedInput behavior is unchanged.
  • Append feedback after post hooks so output replacement cannot erase it; ignore blank/failed-hook context and avoid duplicate denial messages.
  • Keep four focused regression cases and concise hook documentation. Plugin merging and brepl changes are separate.

Verification

  • 68 tests, 344 assertions passed across tool calls, chat lifecycle, and hooks.
  • Focused Clojure lint, editor diagnostics, and whitespace checks passed.

🤖 Generated with ECA (openai/gpt-6-astra)

Successful preToolCall warnings were visible in the UI but absent from
model context. Append them to the matching tool result after post hooks
so output replacement cannot erase them, without duplicating denials.
@zikajk

zikajk commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Closing as out of scope for the brepl integration. Pre-tool hooks will continue to adjust or reject input; post-tool hooks will report repairs and evaluation results. The existing updatedInput behavior is sufficient, so this general pre-hook context-delivery extension is not needed. PR #592 is separate and unchanged.

@zikajk zikajk closed this Sep 10, 2026
@zikajk
zikajk deleted the fix/hook-feedback branch September 10, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant