mw/com: Add Field Getter support - #758
Draft
bemerybmw wants to merge 7 commits into
Draft
Conversation
bemerybmw
force-pushed
the
brem_field_getter
branch
3 times, most recently
from
July 30, 2026 06:29
41f7c2e to
343db54
Compare
Contributor
|
If you are done with this PR, don't forget to update the tutorial: Chapter 9 |
bemerybmw
force-pushed
the
brem_field_getter
branch
from
July 31, 2026 06:49
343db54 to
1363a04
Compare
Previously, the find service handler was occassionally called after the ConsumerActions was destroyed. The handler held references to objects in ConsumerActions (such as a mutex) which were accessed in the handler after they'd already been destroyed. Calling StopFindService prevents this issue.
AssertMethodHandlerSupportsMethodSignature now accepts an additional template parameter which determines whether it should check that QualityType is passed as the first argument.
For a Field getter, we are interested in the asil level of the ProxyField which called the method (so that we can reference the slot in the asil b or qm control vector). In the future, this may also be interesting to general users of methods. However, for the moment we make this a private interface accessible only to a field getter and can make it public in the future if we see the need.
Since the wetter function can fail within the middleware code (e.g. when trying to read the latest value of the field fails), we need to return a result from the setter and getter.
Since the method handlers for the field getters are registered in the SkeletonField::PrepareOffer() function, we need to verify that all method handlers have been registered after the calling PrepareOffer() on the SkeletonFields.
bemerybmw
force-pushed
the
brem_field_getter
branch
from
July 31, 2026 10:03
1363a04 to
2493765
Compare
| { | ||
| TRUE, | ||
| FALSE | ||
| }; |
Contributor
There was a problem hiding this comment.
I think the enum value should be something like kYes or kNo or something like kWithQualityType/kWithoutQualityType instead of true or false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over: #438