Add SkeletonField::Get support (EnableGet flag) - #438
Closed
Tejveerpratap2803 wants to merge 6 commits into
Closed
Conversation
Tejveerpratap2803
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
May 18, 2026 01:51
Tejveerpratap2803
marked this pull request as draft
May 18, 2026 01:51
Tejveerpratap2803
changed the title
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
4 times, most recently
from
June 1, 2026 06:16
b48d1b6 to
c45fc0c
Compare
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
4 times, most recently
from
June 3, 2026 12:51
c8fce55 to
05289f4
Compare
Tejveerpratap2803
marked this pull request as ready for review
June 3, 2026 13:40
bemerybmw
marked this pull request as draft
June 10, 2026 11:27
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment or push new changes to keep it open. |
|
This pull request has been automatically closed due to inactivity. Feel free to reopen it if you would like to continue working on it. |
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
3 times, most recently
from
July 21, 2026 14:28
f7d3296 to
0b3526f
Compare
Tejveerpratap2803
marked this pull request as ready for review
July 21, 2026 18:33
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
2 times, most recently
from
July 26, 2026 18:48
37e7c5a to
38af1d3
Compare
- Automatically register a Get handler for fields with EnableGet. - Serve Get requests by reading the latest field value and returning it through the Get method. - Add a test covering this behavior. Issue: SWP-249517
- pass additional_slots through field binding creation - compute additional_slots from EnableSet || EnableGet - use configured_slots + additional_slots in event properties - add unit tests for +1 and default (unchanged) slot count
- Added the RegisterHandler(callback, QualityType) overload - Extended TypeErasedCallbackSignature with QualityType as 3rd param - Capture asil_level in OnProxyMethodSubscribeFinished so each proxy connection carries its own ASIL level at call time - Updated BUILD visibility/deps for quality type
- Update RegisterGetHandler() to use QualityType-aware RegisterHandler overload - Fixed the unit test case by adding qualitytype as param
…d fixed clang tidy error
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
3 times, most recently
from
July 26, 2026 20:21
104b4b3 to
a5caed5
Compare
- Pass WithGetter tag presence from SkeletonField down to lola::SkeletonEvent via the field binding factory chain, replacing the hard-coded false value. - Merge both RegisterHandler overloads into one RegisterHandlerImpl and passed QualityType only when the callback accepts it - Expose all args of CreateEventBinding in mock
Tejveerpratap2803
force-pushed
the
muse_skeleton_field_enable_get
branch
from
July 26, 2026 21:25
a5caed5 to
f6e420a
Compare
Contributor
|
Taken over in: #758 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mw/com/impl: introduces and implements SkeletonField::Get