Show a successful SSO provider test in green - #271
Merged
Merged
Conversation
Testing the single sign-on provider showed "The provider answered" in the same plain gray box as any note, while "Could not reach the provider" was already red. A good answer now gets the matching green: a green-tinted box and a green shield, from the same color the dashboard uses for queries without errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the single sign-on provider showed The provider answered in the same plain gray box as any note, while Could not reach the provider was already red. A good answer now gets the matching green: a green-tinted box and a green shield. The green is
--metric-no-error, the color the dashboard uses for queries without errors, and the rule mirrors the existing red one.TestSSOCheckResultIsGreenOrRedchecks both results.Screenshots
The Vandelay demo has no SSO provider, so each shot renders the SSO card with a test result, from main or from this branch, and places it on that demo's Integrations page, which supplies the page's real styles and fonts. Failure is unchanged and shown for comparison.
Provider answered: laptop (dark, light) and phone
Provider unreachable (unchanged)
Checks
go tool mage verifyandgofmt -l .