Color the remaining result notices by what they mean - #273
Merged
Merged
Conversation
Testing the single sign-on provider showed "The provider answered" in the same plain gray box as any note, while "Could not reach the provider" was already red. A good answer now gets the matching green: a green-tinted box and a green shield, from the same color the dashboard uses for queries without errors.
A few on-page notices didn't follow green for success, amber for a warning, and red for a failure: - The single sign-on wizard showed the provider's answer in a plain gray box. It is green now, like the card's since the last change. - Creating the MCP Server group said it worked in plain gray text, while failing to said so in a red box. It is a green box now. - "Sign-in is off on this server" and "This address is not HTTPS" were red boxes on the MCP card but blue notes in its setup wizard. Nothing has failed, so both places show them as the same amber warning. - A failed rolling update showed its reason in plain gray text. It is a red box now, and one an operator stopped is an amber one. The notice box gains an amber variant beside its green and red ones, in the amber the console's other warnings use.
drudge
enabled auto-merge (squash)
September 29, 2026 16:47
# Conflicts: # internal/web/assets/app.css # internal/web/pages/integrations_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #271, which made the SSO card's test result green.
A few on-page notices didn't follow green for success, amber for a warning, and red for a failure:
The notice box (
.unifi-status) gains an amberwarningvariant beside itssuccessanderrorones, in the amber (#d97706) the console's other warnings use. Tests cover each notice, and fail against the old markup.Screenshots
These states need a live identity provider, an MCP group being created, or a rollout that fails, which the Vandelay demo can't produce on its own. So each shot renders the real component, from main or from this branch, and places it on that demo's page, which supplies the real styles and fonts. Dark and light.
Single sign-on wizard: the provider answered
MCP setup: the group was created
MCP setup: the address isn't HTTPS
MCP card: the same warning
Rolling update failed
Rolling update stopped by an operator
Checks
go tool mage verifyandgofmt -l .TestBrowserwith Chrome