Skip to content

Reject unfinished pagination before reporting resolved review threads #358

Closed

Description

@devantler

🤖 Generated by the Agentic Engineer

Problem

The unresolved-thread helper reports unresolved=0 total=1 with exit 0 when its last page still says hasNextPage: true. Matching the total does not prove that the page chain completed.

Reproduced against current main 3538221 using the shipped public command and an isolated offline fixture.

Proposed direction

Require valid pagination metadata, intermediate continuation, and a terminal final page; return UNKNOWN for a missing, malformed or unfinished chain.

Acceptance criteria

  • A complete one-page and multi-page response still counts correctly; unfinished and malformed page chains return exit 2.
  • Add a failing regression first, preserve valid behavior, and verify the merged public command.

Size: S. Part of #38.

Activity

  1. self-assigned this
    on Oct 2, 2026
  2. added theissue type on Oct 2, 2026
  3. devantler commented on Oct 3, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Delivered in #365, merged at 3e7afb4 after clean current-head review and CI. The actual merged collectors and installed wrapper passed their public-command tests, and exact-main CI passed all 32 jobs. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Fields

Priority

None yet

Effort

None yet

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions