Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/danger-comment.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Danger Comment

on:
workflow_run:
workflows: [Danger]
types: [completed]

permissions:
actions: read
issues: write
pull-requests: write

jobs:
comment:
uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@v0.1.0
secrets: inherit
26 changes: 9 additions & 17 deletions .github/workflows/danger.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
name: PR Linter
on: [pull_request]
name: Danger
on:
pull_request:
types: [opened, reopened, edited, synchronize]
jobs:
danger:
runs-on: ubuntu-latest
env:
BUNDLE_GEMFILE: ${{ github.workspace }}/Gemfile.danger
steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler-cache: true
- run: |
# the personal token is public, this is ok, base64 encode to avoid tripping Github
TOKEN=$(echo -n Z2hwX0xNQ3VmanBFeTBvYkZVTWh6NVNqVFFBOEUxU25abzBqRUVuaAo= | base64 --decode)
DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose
uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0
secrets: inherit
with:
ruby-version: "3.4"
danger-args: "dry_run --base=origin/master"
4 changes: 2 additions & 2 deletions .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v7
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0
ruby-version: 3.4
bundler-cache: true
- run: bundle exec rubocop
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ jobs:
strategy:
matrix:
ruby-version:
- "3.0"
- "3.1"
- "3.2"
- "3.3"
- "3.4"
- "4.0"
- "jruby-9.4"
- "jruby-10"
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v7
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### 3.1.0 (Next)

* [#100](https://github.com/dblock/strava-ruby-client/pull/100): Adds comprehensive rdoc documentation - [@dblock](https://github.com/dblock).
* [#103](https://github.com/dblock/strava-ruby-client/pull/103): Migrate Danger to use the `danger-pr-comment` reusable workflow - [@dblock](https://github.com/dblock), [@Copilot](https://github.com/apps/copilot-swe-agent).
* Your contribution here.

### 3.0.0 (2025/10/24)
Expand Down
4 changes: 3 additions & 1 deletion Dangerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# frozen_string_literal: true

danger.import_dangerfile(gem: 'danger-pr-comment')

toc.check!
changelog.check
changelog.check!
3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ gemspec

group :development, :test do
gem 'csv'
gem 'danger-changelog', '~> 0.8.0'
gem 'danger-pr-comment'
gem 'danger-toc', '~> 0.2.0'
gem 'dotenv'
gem 'faraday-retry'
gem 'gpx'
Expand Down
6 changes: 0 additions & 6 deletions Gemfile.danger

This file was deleted.

Loading