Skip to content

Migrate Danger to use danger-pr-comment workflow and modernize CI - #103

Merged
dblock merged 1 commit into
masterfrom
dblock/migrate-danger-modernize-ci
Aug 24, 2026
Merged

Migrate Danger to use danger-pr-comment workflow and modernize CI#103
dblock merged 1 commit into
masterfrom
dblock/migrate-danger-modernize-ci

Conversation

@dblock

@dblock dblock commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Migrate Danger to use the danger-pr-comment reusable workflow (as in dblock/open-weather-ruby-client#49) and modernize CI (as in dblock/open-weather-ruby-client#48).

  • Replace danger.yml's inline bundle exec danger step (hardcoded/expired PAT) with a call to numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0 (uses GITHUB_TOKEN).
  • Add danger-comment.yml workflow to post PR comments on Danger completion.
  • Merge Gemfile.danger dependencies into the main Gemfile (danger gems), upgrade danger-changelog to 0.8.0, add danger-pr-comment. Remove the now-unused Gemfile.danger.
  • Import danger-pr-comment's Dangerfile plugin, use check! instead of deprecated check.
  • Bump actions/checkout v5 → v7 in all workflows.
  • Test matrix: drop EOL Ruby 3.0, add Ruby 4.0.
  • Bump RuboCop job's pinned Ruby from 3.0 → 3.4.

dblock added a commit that referenced this pull request Aug 24, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the dblock/migrate-danger-modernize-ci branch from 374223e to 3a3c91e Compare August 24, 2026 14:23
@dblock
dblock merged commit 64ecd2e into master Aug 24, 2026
17 checks passed
@dblock
dblock deleted the dblock/migrate-danger-modernize-ci branch August 24, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant